diff options
author | RĂ©mi Verschelde <remi@verschelde.fr> | 2021-08-12 09:44:05 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-08-12 09:44:05 +0200 |
commit | 22ccb74aff00f7b073e3eb4f0c26fec858ef1884 (patch) | |
tree | 3134b2514e80be7398a159997da2e5af965cc7ec /servers | |
parent | 1c5a8592ca3fe6095f7af4a8f6cfa16956b9142a (diff) | |
parent | 63c7d5c330fa805a9db900a4ed365a8a1338fefc (diff) |
Merge pull request #51548 from Chaosus/shader_silence_error
Removes an internal error report if shader fails compile
Diffstat (limited to 'servers')
-rw-r--r-- | servers/rendering/renderer_rd/forward_clustered/scene_shader_forward_clustered.cpp | 5 | ||||
-rw-r--r-- | servers/rendering/renderer_rd/shader_rd.h | 4 |
2 files changed, 6 insertions, 3 deletions
diff --git a/servers/rendering/renderer_rd/forward_clustered/scene_shader_forward_clustered.cpp b/servers/rendering/renderer_rd/forward_clustered/scene_shader_forward_clustered.cpp index 333e87bdbd..89d14e871a 100644 --- a/servers/rendering/renderer_rd/forward_clustered/scene_shader_forward_clustered.cpp +++ b/servers/rendering/renderer_rd/forward_clustered/scene_shader_forward_clustered.cpp @@ -131,8 +131,9 @@ void SceneShaderForwardClustered::ShaderData::set_code(const String &p_code) { SceneShaderForwardClustered *shader_singleton = (SceneShaderForwardClustered *)SceneShaderForwardClustered::singleton; Error err = shader_singleton->compiler.compile(RS::SHADER_SPATIAL, code, &actions, path, gen_code); - - ERR_FAIL_COND(err != OK); + if (err != OK) { + return; + } if (version.is_null()) { version = shader_singleton->shader.version_create(); diff --git a/servers/rendering/renderer_rd/shader_rd.h b/servers/rendering/renderer_rd/shader_rd.h index 529328f0ed..44705b2bd6 100644 --- a/servers/rendering/renderer_rd/shader_rd.h +++ b/servers/rendering/renderer_rd/shader_rd.h @@ -142,7 +142,9 @@ public: ERR_FAIL_COND_V(!variants_enabled[p_variant], RID()); Version *version = version_owner.getornull(p_version); - ERR_FAIL_COND_V(!version, RID()); + if (!version) { + return RID(); + } if (version->dirty) { _compile_version(version); |