summaryrefslogtreecommitdiff
path: root/servers/visual
diff options
context:
space:
mode:
authorRémi Verschelde <rverschelde@gmail.com>2018-04-19 13:04:41 +0200
committerRémi Verschelde <rverschelde@gmail.com>2018-04-19 15:20:45 +0200
commitbf7ca623a65f25cc4ac7a3ca0d6635331ec07c25 (patch)
tree40f6fa11f7dd41fd51343af01e1e298a2f7fd859 /servers/visual
parent394e6d5ee1479d402892d6df75dddceeb967efcc (diff)
Fix Coverity reports of uninitialized scalar variable
Fixes most current reports on Coverity Scan of uninitialized scalar variable (CWE-457): https://cwe.mitre.org/data/definitions/457.html These happen most of the time (in our code) when instanciating structs without a constructor (or with an incomplete one), and later returning the instance. This is sometimes intended though, as some parameters are only used in some situations and should not be double-initialized for performance reasons (e.g. `constant` in ShaderLanguage::Token).
Diffstat (limited to 'servers/visual')
-rw-r--r--servers/visual/shader_language.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/servers/visual/shader_language.h b/servers/visual/shader_language.h
index e8cdf1f897..2e3881179a 100644
--- a/servers/visual/shader_language.h
+++ b/servers/visual/shader_language.h
@@ -425,6 +425,7 @@ public:
FunctionNode() {
type = TYPE_FUNCTION;
+ return_type = TYPE_VOID;
return_precision = PRECISION_DEFAULT;
can_discard = false;
}