summaryrefslogtreecommitdiff
path: root/modules/gltf/structures
diff options
context:
space:
mode:
authorAaron Franke <arnfranke@yahoo.com>2022-09-04 09:42:03 -0500
committerAaron Franke <arnfranke@yahoo.com>2022-09-04 09:52:25 -0500
commit133e5d197b00fcd8f4b967d2b0c99f14effa4478 (patch)
treecedf8623fb9da7078160735cad18cc09b5668575 /modules/gltf/structures
parente7a0a97c0bc5d86644e62d537503e3b05313a01c (diff)
Don't try to read values from null cameras and lights in GLTF
Diffstat (limited to 'modules/gltf/structures')
-rw-r--r--modules/gltf/structures/gltf_camera.cpp1
1 files changed, 1 insertions, 0 deletions
diff --git a/modules/gltf/structures/gltf_camera.cpp b/modules/gltf/structures/gltf_camera.cpp
index 5069f39c4b..212b9b80c8 100644
--- a/modules/gltf/structures/gltf_camera.cpp
+++ b/modules/gltf/structures/gltf_camera.cpp
@@ -58,6 +58,7 @@ void GLTFCamera::_bind_methods() {
Ref<GLTFCamera> GLTFCamera::from_node(const Camera3D *p_camera) {
Ref<GLTFCamera> c;
c.instantiate();
+ ERR_FAIL_COND_V_MSG(!p_camera, c, "Tried to create a GLTFCamera from a Camera3D node, but the given node was null.");
c->set_perspective(p_camera->get_projection() == Camera3D::ProjectionType::PROJECTION_PERSPECTIVE);
// GLTF spec (yfov) is in radians, Godot's camera (fov) is in degrees.
c->set_fov(Math::deg_to_rad(p_camera->get_fov()));