From 4a59f683d3772edd9233e93e1bee9c99400502f4 Mon Sep 17 00:00:00 2001 From: marynate Date: Mon, 23 Jun 2014 23:43:37 +0800 Subject: Fix bug help history overwrote by tree item selected call back --- tools/editor/editor_help.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'tools') diff --git a/tools/editor/editor_help.cpp b/tools/editor/editor_help.cpp index 0471d62d16..8598ea4c89 100644 --- a/tools/editor/editor_help.cpp +++ b/tools/editor/editor_help.cpp @@ -406,7 +406,6 @@ void EditorHelp::_class_list_select(const String& p_select) { void EditorHelp::_class_desc_select(const String& p_select) { if (p_select.begins_with("#")) { - _goto_desc(p_select.substr(1,p_select.length())); return; } else if (p_select.begins_with("@")) { @@ -469,9 +468,11 @@ Error EditorHelp::_goto_desc(const String& p_class,bool p_update_history,int p_v if (tree_item_map.has(p_class)) { + select_locked = true; tree_item_map[p_class]->select(0); class_list->ensure_cursor_is_visible(); } + class_desc->show(); //tabs->set_current_tab(PAGE_CLASS_DESC); edited_class->set_pressed(true); @@ -497,7 +498,6 @@ Error EditorHelp::_goto_desc(const String& p_class,bool p_update_history,int p_v class_desc->clear(); method_line.clear(); - edited_class->set_text(p_class); //edited_class->show(); @@ -870,7 +870,7 @@ Error EditorHelp::_goto_desc(const String& p_class,bool p_update_history,int p_v return OK; } -void EditorHelp::_request_help(const String& p_string) { +void EditorHelp::_request_help(const String& p_string) { Error err = _goto_desc(p_string); if (err==OK) { editor->call("_editor_select",3); @@ -1231,8 +1231,10 @@ void EditorHelp::_notification(int p_what) { void EditorHelp::_tree_item_selected() { - if (select_locked) + if (select_locked) { + select_locked = false; return; + } TreeItem *s=class_list->get_selected(); if (!s) return; @@ -1280,7 +1282,6 @@ EditorHelp::EditorHelp(EditorNode *p_editor) { edited_class->hide(); b->set_toggle_mode(true); b->connect("pressed",this,"_button_pressed",make_binds(PAGE_CLASS_DESC)); - edited_class->hide(); b = memnew( Button ); b->set_text("Search in Classes"); -- cgit v1.2.3