From e9d213e0fdf30505febc3ca3ebaa9aeffc3a30c0 Mon Sep 17 00:00:00 2001
From: dzil123 <5725958+dzil123@users.noreply.github.com>
Date: Thu, 17 Nov 2022 03:41:55 -0800
Subject: RendererDummy fix buffer overflow due to mesh_get_surface

---
 servers/rendering/dummy/storage/mesh_storage.cpp | 7 +++++++
 servers/rendering/dummy/storage/mesh_storage.h   | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

(limited to 'servers')

diff --git a/servers/rendering/dummy/storage/mesh_storage.cpp b/servers/rendering/dummy/storage/mesh_storage.cpp
index adf736eee3..52de998835 100644
--- a/servers/rendering/dummy/storage/mesh_storage.cpp
+++ b/servers/rendering/dummy/storage/mesh_storage.cpp
@@ -56,3 +56,10 @@ void MeshStorage::mesh_free(RID p_rid) {
 
 	mesh_owner.free(p_rid);
 }
+
+void MeshStorage::mesh_clear(RID p_mesh) {
+	DummyMesh *m = mesh_owner.get_or_null(p_mesh);
+	ERR_FAIL_COND(!m);
+
+	m->surfaces.clear();
+}
diff --git a/servers/rendering/dummy/storage/mesh_storage.h b/servers/rendering/dummy/storage/mesh_storage.h
index 4399f4ab66..28fe8cb80d 100644
--- a/servers/rendering/dummy/storage/mesh_storage.h
+++ b/servers/rendering/dummy/storage/mesh_storage.h
@@ -116,7 +116,7 @@ public:
 
 	virtual AABB mesh_get_aabb(RID p_mesh, RID p_skeleton = RID()) override { return AABB(); }
 	virtual void mesh_set_shadow_mesh(RID p_mesh, RID p_shadow_mesh) override {}
-	virtual void mesh_clear(RID p_mesh) override {}
+	virtual void mesh_clear(RID p_mesh) override;
 
 	/* MESH INSTANCE */
 
-- 
cgit v1.2.3