From 7adb6b91b33e297b4833ef5f82adcf64a15777f4 Mon Sep 17 00:00:00 2001 From: Hugo Locurcio Date: Tue, 3 Nov 2020 00:21:06 +0100 Subject: Remove `Color.contrasted()` as its behavior is barely useful Returning the most contrasting color isn't a trivial task, as there are often many possible choices. It's usually best left for the user to implement using a script. --- modules/gdnative/gdnative/color.cpp | 7 ------- modules/gdnative/gdnative_api.json | 7 ------- modules/gdnative/include/gdnative/color.h | 2 -- modules/mono/glue/GodotSharp/GodotSharp/Core/Color.cs | 14 -------------- 4 files changed, 30 deletions(-) (limited to 'modules') diff --git a/modules/gdnative/gdnative/color.cpp b/modules/gdnative/gdnative/color.cpp index c75e74daba..e08183ab63 100644 --- a/modules/gdnative/gdnative/color.cpp +++ b/modules/gdnative/gdnative/color.cpp @@ -148,13 +148,6 @@ godot_color GDAPI godot_color_inverted(const godot_color *p_self) { return dest; } -godot_color GDAPI godot_color_contrasted(const godot_color *p_self) { - godot_color dest; - const Color *self = (const Color *)p_self; - *((Color *)&dest) = self->contrasted(); - return dest; -} - godot_color GDAPI godot_color_lerp(const godot_color *p_self, const godot_color *p_b, const godot_real p_t) { godot_color dest; const Color *self = (const Color *)p_self; diff --git a/modules/gdnative/gdnative_api.json b/modules/gdnative/gdnative_api.json index 82bfbd23de..40d0f75871 100644 --- a/modules/gdnative/gdnative_api.json +++ b/modules/gdnative/gdnative_api.json @@ -1254,13 +1254,6 @@ ["const godot_color *", "p_self"] ] }, - { - "name": "godot_color_contrasted", - "return_type": "godot_color", - "arguments": [ - ["const godot_color *", "p_self"] - ] - }, { "name": "godot_color_lerp", "return_type": "godot_color", diff --git a/modules/gdnative/include/gdnative/color.h b/modules/gdnative/include/gdnative/color.h index e7737bf8e1..e64097ef57 100644 --- a/modules/gdnative/include/gdnative/color.h +++ b/modules/gdnative/include/gdnative/color.h @@ -93,8 +93,6 @@ godot_int GDAPI godot_color_to_argb32(const godot_color *p_self); godot_color GDAPI godot_color_inverted(const godot_color *p_self); -godot_color GDAPI godot_color_contrasted(const godot_color *p_self); - godot_color GDAPI godot_color_lerp(const godot_color *p_self, const godot_color *p_b, const godot_real p_t); godot_color GDAPI godot_color_blend(const godot_color *p_self, const godot_color *p_over); diff --git a/modules/mono/glue/GodotSharp/GodotSharp/Core/Color.cs b/modules/mono/glue/GodotSharp/GodotSharp/Core/Color.cs index 3700a6194f..d0add835c0 100644 --- a/modules/mono/glue/GodotSharp/GodotSharp/Core/Color.cs +++ b/modules/mono/glue/GodotSharp/GodotSharp/Core/Color.cs @@ -256,20 +256,6 @@ namespace Godot return res; } - /// - /// Returns the most contrasting color. - /// - /// The most contrasting color - public Color Contrasted() - { - return new Color( - (r + 0.5f) % 1.0f, - (g + 0.5f) % 1.0f, - (b + 0.5f) % 1.0f, - a - ); - } - /// /// Returns a new color resulting from making this color darker /// by the specified ratio (on the range of 0 to 1). -- cgit v1.2.3