From 24bcbe971a39c5845be3a225f5c89c3a352775d2 Mon Sep 17 00:00:00 2001 From: George Marques Date: Tue, 24 May 2022 13:40:36 -0300 Subject: GDScript: Don't show redundant await warning on unknown types Also avoid it when the type is known to be a signal. --- .../analyzer/features/await_with_signals_no_warning.gd | 12 ++++++++++++ .../analyzer/features/await_with_signals_no_warning.out | 2 ++ 2 files changed, 14 insertions(+) create mode 100644 modules/gdscript/tests/scripts/analyzer/features/await_with_signals_no_warning.gd create mode 100644 modules/gdscript/tests/scripts/analyzer/features/await_with_signals_no_warning.out (limited to 'modules/gdscript/tests/scripts/analyzer') diff --git a/modules/gdscript/tests/scripts/analyzer/features/await_with_signals_no_warning.gd b/modules/gdscript/tests/scripts/analyzer/features/await_with_signals_no_warning.gd new file mode 100644 index 0000000000..9a7c6a8250 --- /dev/null +++ b/modules/gdscript/tests/scripts/analyzer/features/await_with_signals_no_warning.gd @@ -0,0 +1,12 @@ +# https://github.com/godotengine/godot/issues/54589 +# https://github.com/godotengine/godot/issues/56265 + +extends Resource + +func test(): + print("okay") + await self.changed + await unknown(self) + +func unknown(arg): + await arg.changed diff --git a/modules/gdscript/tests/scripts/analyzer/features/await_with_signals_no_warning.out b/modules/gdscript/tests/scripts/analyzer/features/await_with_signals_no_warning.out new file mode 100644 index 0000000000..2dc04a363e --- /dev/null +++ b/modules/gdscript/tests/scripts/analyzer/features/await_with_signals_no_warning.out @@ -0,0 +1,2 @@ +GDTEST_OK +okay -- cgit v1.2.3