From ac3322b0af8f23e8e2dac8111200bc69b5604c9f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9mi=20Verschelde?= <rverschelde@gmail.com>
Date: Sat, 24 Jul 2021 15:46:25 +0200
Subject: Use const references where possible for List range iterators

---
 modules/gdscript/gdscript.cpp | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

(limited to 'modules/gdscript/gdscript.cpp')

diff --git a/modules/gdscript/gdscript.cpp b/modules/gdscript/gdscript.cpp
index 79cc90b92f..b3975fa95c 100644
--- a/modules/gdscript/gdscript.cpp
+++ b/modules/gdscript/gdscript.cpp
@@ -291,7 +291,7 @@ void GDScript::_get_script_property_list(List<PropertyInfo> *r_list, bool p_incl
 		sptr = sptr->_base;
 	}
 
-	for (PropertyInfo &E : props) {
+	for (const PropertyInfo &E : props) {
 		r_list->push_back(E);
 	}
 }
@@ -401,7 +401,7 @@ void GDScript::_update_exports_values(Map<StringName, Variant> &values, List<Pro
 		values[E->key()] = E->get();
 	}
 
-	for (PropertyInfo &E : members_cache) {
+	for (const PropertyInfo &E : members_cache) {
 		propnames.push_back(E);
 	}
 }
@@ -861,8 +861,7 @@ Error GDScript::reload(bool p_keep_state) {
 		}
 	}
 #ifdef DEBUG_ENABLED
-	for (const GDScriptWarning &E : parser.get_warnings()) {
-		const GDScriptWarning &warning = E;
+	for (const GDScriptWarning &warning : parser.get_warnings()) {
 		if (EngineDebugger::is_active()) {
 			Vector<ScriptLanguage::StackInfo> si;
 			EngineDebugger::get_script_debugger()->send_error("", get_path(), warning.start_line, warning.get_name(), warning.get_message(), ERR_HANDLER_WARNING, si);
@@ -1445,7 +1444,7 @@ void GDScriptInstance::get_property_list(List<PropertyInfo> *p_properties) const
 		sptr = sptr->_base;
 	}
 
-	for (PropertyInfo &E : props) {
+	for (const PropertyInfo &E : props) {
 		p_properties->push_back(E);
 	}
 }
@@ -1661,7 +1660,7 @@ void GDScriptLanguage::init() {
 
 	List<Engine::Singleton> singletons;
 	Engine::get_singleton()->get_singletons(&singletons);
-	for (Engine::Singleton &E : singletons) {
+	for (const Engine::Singleton &E : singletons) {
 		_add_global(E.name, E.ptr);
 	}
 
-- 
cgit v1.2.3