From 85aa03baaf179707fabbb3e7fa07a989f5535c23 Mon Sep 17 00:00:00 2001 From: Christoh Prenissl Date: Mon, 16 Jan 2023 22:32:23 +0100 Subject: Checking path variable if empty before opening external editor to fix #71528 --- editor/plugins/script_editor_plugin.cpp | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'editor/plugins') diff --git a/editor/plugins/script_editor_plugin.cpp b/editor/plugins/script_editor_plugin.cpp index 4268abe4a2..8777b73540 100644 --- a/editor/plugins/script_editor_plugin.cpp +++ b/editor/plugins/script_editor_plugin.cpp @@ -2256,11 +2256,14 @@ bool ScriptEditor::edit(const Ref &p_resource, int p_line, int p_col, args.push_back(script_path); } - Error err = OS::get_singleton()->create_process(path, args); - if (err == OK) { - return false; + if (!path.is_empty()) { + Error err = OS::get_singleton()->create_process(path, args); + if (err == OK) { + return false; + } } - WARN_PRINT("Couldn't open external text editor, using internal"); + + ERR_PRINT("Couldn't open external text editor, falling back to the internal editor. Review your `text_editor/external/` editor settings."); } for (int i = 0; i < tab_container->get_tab_count(); i++) { -- cgit v1.2.3