From 0be6d925dc3c6413bce7a3ccb49631b8e4a6e67a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Verschelde?= Date: Thu, 14 May 2020 13:23:58 +0200 Subject: Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks Which means that reduz' beloved style which we all became used to will now be changed automatically to remove the first empty line. This makes us lean closer to 1TBS (the one true brace style) instead of hybridating it with some Allman-inspired spacing. There's still the case of braces around single-statement blocks that needs to be addressed (but clang-format can't help with that, but clang-tidy may if we agree about it). Part of #33027. --- editor/editor_vcs_interface.cpp | 26 -------------------------- 1 file changed, 26 deletions(-) (limited to 'editor/editor_vcs_interface.cpp') diff --git a/editor/editor_vcs_interface.cpp b/editor/editor_vcs_interface.cpp index 6f3a8d9ea7..4b13a5dd89 100644 --- a/editor/editor_vcs_interface.cpp +++ b/editor/editor_vcs_interface.cpp @@ -33,7 +33,6 @@ EditorVCSInterface *EditorVCSInterface::singleton = nullptr; void EditorVCSInterface::_bind_methods() { - // Proxy end points that act as fallbacks to unavailability of a function in the VCS addon ClassDB::bind_method(D_METHOD("_initialize", "project_root_path"), &EditorVCSInterface::_initialize); ClassDB::bind_method(D_METHOD("_is_vcs_initialized"), &EditorVCSInterface::_is_vcs_initialized); @@ -62,18 +61,15 @@ void EditorVCSInterface::_bind_methods() { } bool EditorVCSInterface::_initialize(String p_project_root_path) { - WARN_PRINT("Selected VCS addon does not implement an initialization function. This warning will be suppressed."); return true; } bool EditorVCSInterface::_is_vcs_initialized() { - return false; } Dictionary EditorVCSInterface::_get_modified_files_data() { - return Dictionary(); } @@ -87,96 +83,76 @@ void EditorVCSInterface::_commit(String p_msg) { } Array EditorVCSInterface::_get_file_diff(String p_file_path) { - return Array(); } bool EditorVCSInterface::_shut_down() { - return false; } String EditorVCSInterface::_get_project_name() { - return String(); } String EditorVCSInterface::_get_vcs_name() { - return ""; } bool EditorVCSInterface::initialize(String p_project_root_path) { - is_initialized = call("_initialize", p_project_root_path); return is_initialized; } bool EditorVCSInterface::is_vcs_initialized() { - return call("_is_vcs_initialized"); } Dictionary EditorVCSInterface::get_modified_files_data() { - return call("_get_modified_files_data"); } void EditorVCSInterface::stage_file(String p_file_path) { - if (is_addon_ready()) { - call("_stage_file", p_file_path); } } void EditorVCSInterface::unstage_file(String p_file_path) { - if (is_addon_ready()) { - call("_unstage_file", p_file_path); } } bool EditorVCSInterface::is_addon_ready() { - return is_initialized; } void EditorVCSInterface::commit(String p_msg) { - if (is_addon_ready()) { - call("_commit", p_msg); } } Array EditorVCSInterface::get_file_diff(String p_file_path) { - if (is_addon_ready()) { - return call("_get_file_diff", p_file_path); } return Array(); } bool EditorVCSInterface::shut_down() { - return call("_shut_down"); } String EditorVCSInterface::get_project_name() { - return call("_get_project_name"); } String EditorVCSInterface::get_vcs_name() { - return call("_get_vcs_name"); } EditorVCSInterface::EditorVCSInterface() { - is_initialized = false; } @@ -184,11 +160,9 @@ EditorVCSInterface::~EditorVCSInterface() { } EditorVCSInterface *EditorVCSInterface::get_singleton() { - return singleton; } void EditorVCSInterface::set_singleton(EditorVCSInterface *p_singleton) { - singleton = p_singleton; } -- cgit v1.2.3