From cacced7e507f7603bacc03ae2616e58f0ede122a Mon Sep 17 00:00:00 2001 From: Hein-Pieter van Braam Date: Thu, 24 Aug 2017 22:58:51 +0200 Subject: Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/ --- drivers/png/resource_saver_png.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers') diff --git a/drivers/png/resource_saver_png.cpp b/drivers/png/resource_saver_png.cpp index 4f1f318aee..876fb820b2 100644 --- a/drivers/png/resource_saver_png.cpp +++ b/drivers/png/resource_saver_png.cpp @@ -187,7 +187,7 @@ bool ResourceSaverPNG::recognize(const RES &p_resource) const { } void ResourceSaverPNG::get_recognized_extensions(const RES &p_resource, List *p_extensions) const { - if (p_resource->cast_to()) { + if (Object::cast_to(*p_resource)) { p_extensions->push_back("png"); } } -- cgit v1.2.3