From 80178271447455efb7d12ef52f09e8408c042d59 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Verschelde?= Date: Mon, 10 Oct 2022 13:04:01 +0200 Subject: SCons: Re-enable treating `#warning` as error with `werror` Replace all TODO uses of `#warning` by proper TODO comments, and will open matching bug reports to keep track of them. We don't have a great track record fixing TODOs, but I'd wager we're even worse for fixing these "TODO #warning" so we should prohibit this usage. --- SConstruct | 6 ------ 1 file changed, 6 deletions(-) (limited to 'SConstruct') diff --git a/SConstruct b/SConstruct index 77172d4d4c..2c5b34854e 100644 --- a/SConstruct +++ b/SConstruct @@ -732,12 +732,6 @@ if selected_platform in platform_list: if env["werror"]: env.Append(CCFLAGS=["-Werror"]) - # FIXME: Temporary workaround after the Vulkan merge, remove once warnings are fixed. - if methods.using_gcc(env): - env.Append(CXXFLAGS=["-Wno-error=cpp"]) - elif methods.using_clang(env) or methods.using_emcc(env): - env.Append(CXXFLAGS=["-Wno-error=#warnings"]) - if hasattr(detect, "get_program_suffix"): suffix = "." + detect.get_program_suffix() else: -- cgit v1.2.3