From ffc4151f29b21d7e11bb6d1b14171b466bcbe752 Mon Sep 17 00:00:00 2001 From: Yetizone Date: Tue, 20 Oct 2020 00:08:44 +0300 Subject: tonemap.glsl: Ensure color parameter of tonemap_reinhard() is positive Color values can become negative in the case of negative lights which leads to undesired behaviour. --- servers/rendering/rasterizer_rd/shaders/tonemap.glsl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/servers/rendering/rasterizer_rd/shaders/tonemap.glsl b/servers/rendering/rasterizer_rd/shaders/tonemap.glsl index a464048ebd..e7b46a0706 100644 --- a/servers/rendering/rasterizer_rd/shaders/tonemap.glsl +++ b/servers/rendering/rasterizer_rd/shaders/tonemap.glsl @@ -157,6 +157,10 @@ vec3 tonemap_aces(vec3 color, float white) { } vec3 tonemap_reinhard(vec3 color, float white) { + // Ensure color values are positive. + // They can be negative in the case of negative lights, which leads to undesired behavior. + color = max(vec3(0.0), color); + return (white * color + color) / (color * white + white); } -- cgit v1.2.3