From f9f2413e69b9bd821c4e871f1ce46d3a5eafeb0c Mon Sep 17 00:00:00 2001 From: marxin Date: Tue, 2 Apr 2019 14:07:29 +0200 Subject: Fix -Wnon-virtual-dtor warnings. Example of the warning: ./core/script_language.h:198:7: warning: 'class ScriptCodeCompletionCache' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] --- core/script_language.h | 2 ++ drivers/gl_context/context_gl.h | 2 +- scene/gui/text_edit.h | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/core/script_language.h b/core/script_language.h index b6d7bea9c7..005e21e2cc 100644 --- a/core/script_language.h +++ b/core/script_language.h @@ -205,6 +205,8 @@ public: static ScriptCodeCompletionCache *get_singleton() { return singleton; } ScriptCodeCompletionCache(); + + virtual ~ScriptCodeCompletionCache() {} }; class ScriptLanguage { diff --git a/drivers/gl_context/context_gl.h b/drivers/gl_context/context_gl.h index 13141d795c..890683b7c5 100644 --- a/drivers/gl_context/context_gl.h +++ b/drivers/gl_context/context_gl.h @@ -58,7 +58,7 @@ public: virtual bool is_using_vsync() const = 0; ContextGL(); - ~ContextGL(); + virtual ~ContextGL(); }; #endif diff --git a/scene/gui/text_edit.h b/scene/gui/text_edit.h index 95f1fbbee5..33f0a3f45d 100644 --- a/scene/gui/text_edit.h +++ b/scene/gui/text_edit.h @@ -683,6 +683,7 @@ protected: TextEdit *text_editor; public: + virtual ~SyntaxHighlighter() {} virtual void _update_cache() = 0; virtual Map _get_line_syntax_highlighting(int p_line) = 0; -- cgit v1.2.3