From fe52c6b0b7e21bbed1aaabe684714a9b78c23ba3 Mon Sep 17 00:00:00 2001
From: Tomer Keren <tomer.keren.dev@gmail.com>
Date: Fri, 16 Oct 2020 14:04:24 +0300
Subject: Setting visibility on GridMap now works. Closes #41374.
Continuing the work from f43a0ef3270737d2b526480ecb0f1337ece9e041,
It seems the maps visibility was not actually set and a flase value was propogated to the meshes
Trying to set the maps visibility directly (Using `set_visibility` causes the map to no longer to recieve visibility notifications, instead this approach was chosen
---
modules/gridmap/grid_map.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/modules/gridmap/grid_map.cpp b/modules/gridmap/grid_map.cpp
index ccf1e49693..21fa83278b 100644
--- a/modules/gridmap/grid_map.cpp
+++ b/modules/gridmap/grid_map.cpp
@@ -706,7 +706,7 @@ void GridMap::_update_visibility() {
Octant *octant = e->value();
for (int i = 0; i < octant->multimesh_instances.size(); i++) {
const Octant::MultimeshInstance &mi = octant->multimesh_instances[i];
- RS::get_singleton()->instance_set_visible(mi.instance, is_visible());
+ RS::get_singleton()->instance_set_visible(mi.instance, is_visible_in_tree());
}
}
}
--
cgit v1.2.3