From 179646e59372590f024a09468c5d484145210aee Mon Sep 17 00:00:00 2001 From: Fredia Huya-Kouadio Date: Fri, 27 Jan 2023 17:59:28 -0800 Subject: Update the XR manifest configs Remove the ones provided automatically by the loaders, and the ones enabled by the default on the platform. Fixes https://github.com/GodotVR/godot_openxr_loaders/issues/19 --- platform/android/export/export_plugin.cpp | 5 ----- platform/android/export/gradle_export_util.cpp | 11 ----------- platform/android/java/app/AndroidManifest.xml | 9 --------- 3 files changed, 25 deletions(-) diff --git a/platform/android/export/export_plugin.cpp b/platform/android/export/export_plugin.cpp index 587caf81bf..a23f7d1d02 100644 --- a/platform/android/export/export_plugin.cpp +++ b/platform/android/export/export_plugin.cpp @@ -1076,11 +1076,6 @@ void EditorExportPlatformAndroid::_fix_manifest(const Ref &p Vector feature_versions; if (xr_mode_index == XR_MODE_OPENXR) { - // Set degrees of freedom - feature_names.push_back("android.hardware.vr.headtracking"); - feature_required_list.push_back(true); - feature_versions.push_back(1); - // Check for hand tracking if (hand_tracking_index > XR_HAND_TRACKING_NONE) { feature_names.push_back("oculus.software.handtracking"); diff --git a/platform/android/export/gradle_export_util.cpp b/platform/android/export/gradle_export_util.cpp index e450f3edb3..4fdcca68e9 100644 --- a/platform/android/export/gradle_export_util.cpp +++ b/platform/android/export/gradle_export_util.cpp @@ -259,8 +259,6 @@ String _get_xr_features_tag(const Ref &p_preset) { int xr_mode_index = (int)(p_preset->get("xr_features/xr_mode")); bool uses_xr = xr_mode_index == XR_MODE_OPENXR; if (uses_xr) { - manifest_xr_features += " \n"; - int hand_tracking_index = p_preset->get("xr_features/hand_tracking"); // 0: none, 1: optional, 2: required if (hand_tracking_index == XR_HAND_TRACKING_OPTIONAL) { manifest_xr_features += " \n"; @@ -279,8 +277,6 @@ String _get_xr_features_tag(const Ref &p_preset) { } String _get_activity_tag(const Ref &p_preset) { - int xr_mode_index = (int)(p_preset->get("xr_features/xr_mode")); - bool uses_xr = xr_mode_index == XR_MODE_OPENXR; String orientation = _get_android_orientation_label(DisplayServer::ScreenOrientation(int(GLOBAL_GET("display/window/handheld/orientation")))); String manifest_activity_text = vformat( " &p_preset) { bool_to_string(p_preset->get("package/exclude_from_recents")), orientation, bool_to_string(bool(GLOBAL_GET("display/window/size/resizable")))); - if (uses_xr) { - manifest_activity_text += " \n"; - } else { - manifest_activity_text += " \n"; - } manifest_activity_text += " \n"; return manifest_activity_text; } @@ -335,8 +326,6 @@ String _get_application_tag(const Ref &p_preset, bool p_has_ hand_tracking_frequency); manifest_application_text += " \n"; } - } else { - manifest_application_text += " \n"; } manifest_application_text += _get_activity_tag(p_preset); manifest_application_text += " \n"; diff --git a/platform/android/java/app/AndroidManifest.xml b/platform/android/java/app/AndroidManifest.xml index 8c8608cbbb..1969f9c814 100644 --- a/platform/android/java/app/AndroidManifest.xml +++ b/platform/android/java/app/AndroidManifest.xml @@ -48,12 +48,6 @@ android:name="xr_hand_tracking_version_name" android:value="xr_hand_tracking_version_value"/> - - - - - - - -- cgit v1.2.3