From acb23adad37b459e64b8f9bafbbdd1185d46093d Mon Sep 17 00:00:00 2001 From: Leon Krause Date: Tue, 14 Nov 2017 14:52:24 +0100 Subject: Fail when attempting to retrieve a non-existent singleton --- core/engine.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/core/engine.cpp b/core/engine.cpp index d2ef70d82b..31abcd62ef 100644 --- a/core/engine.cpp +++ b/core/engine.cpp @@ -109,15 +109,14 @@ void Engine::add_singleton(const Singleton &p_singleton) { Object *Engine::get_singleton_object(const String &p_name) const { const Map::Element *E = singleton_ptrs.find(p_name); - if (!E) - return NULL; - else - return E->get(); + ERR_EXPLAIN("Failed to retrieve non-existent singleton '" + p_name + "'"); + ERR_FAIL_COND_V(!E, NULL); + return E->get(); }; bool Engine::has_singleton(const String &p_name) const { - return get_singleton_object(p_name) != NULL; + return singleton_ptrs.has(p_name); }; void Engine::get_singletons(List *p_singletons) { -- cgit v1.2.3