From ebd1b0089a5b732afed22247bceefd1a7ef3d4f6 Mon Sep 17 00:00:00 2001 From: Markus Sauermann <6299227+Sauermann@users.noreply.github.com> Date: Wed, 23 Nov 2022 14:13:07 +0100 Subject: Fix Viewport being visible after leaving tree When a SubViewport leaves the tree, it is still displayed in its parent SubViewportContainer until the next redraw. This PR makes sure, that the parent gets redrawn immediately. This also fixes the visibility problem when a SubViewport is added as child of a SubViewportContainer. --- scene/gui/subviewport_container.cpp | 12 ++++++++++++ scene/gui/subviewport_container.h | 3 +++ 2 files changed, 15 insertions(+) diff --git a/scene/gui/subviewport_container.cpp b/scene/gui/subviewport_container.cpp index 3ad84cbc6d..f3d9a22342 100644 --- a/scene/gui/subviewport_container.cpp +++ b/scene/gui/subviewport_container.cpp @@ -227,6 +227,18 @@ void SubViewportContainer::unhandled_input(const Ref &p_event) { } } +void SubViewportContainer::add_child_notify(Node *p_child) { + if (Object::cast_to(p_child)) { + queue_redraw(); + } +} + +void SubViewportContainer::remove_child_notify(Node *p_child) { + if (Object::cast_to(p_child)) { + queue_redraw(); + } +} + PackedStringArray SubViewportContainer::get_configuration_warnings() const { PackedStringArray warnings = Node::get_configuration_warnings(); diff --git a/scene/gui/subviewport_container.h b/scene/gui/subviewport_container.h index 63a58b5f07..fdd8fe9486 100644 --- a/scene/gui/subviewport_container.h +++ b/scene/gui/subviewport_container.h @@ -44,6 +44,9 @@ protected: void _notification(int p_what); static void _bind_methods(); + virtual void add_child_notify(Node *p_child) override; + virtual void remove_child_notify(Node *p_child) override; + public: void set_stretch(bool p_enable); bool is_stretch_enabled() const; -- cgit v1.2.3