From c850ccb7c084e84b536c6fa5f0c667ed49c27cf4 Mon Sep 17 00:00:00 2001 From: Hugo Locurcio Date: Fri, 10 Jun 2022 18:31:40 +0200 Subject: Tweak default crash handler message in exported projects When an exported project crashes, the crash handler message shouldn't reference the Godot issue tracker, as not all crashes are Godot's fault. Reporting crashes that only occur on exported projects is still allowed, but it should not be done by people who aren't working on the project in question. --- doc/classes/ProjectSettings.xml | 7 +++++-- main/main.cpp | 4 +++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/doc/classes/ProjectSettings.xml b/doc/classes/ProjectSettings.xml index 8a3677c0b4..09094ec757 100644 --- a/doc/classes/ProjectSettings.xml +++ b/doc/classes/ProjectSettings.xml @@ -441,8 +441,11 @@ If [code]enabled[/code], prints a warning or an error when assigning the result of a function that returns [code]void[/code] to a variable. - - Message to be displayed before the backtrace when the engine crashes. + + Message to be displayed before the backtrace when the engine crashes. By default, this message is only used in exported projects due to the editor-only override applied to this setting. + + + Editor-only override for [member debug/settings/crash_handler/message]. Does not affect exported projects in debug or release mode. Maximum number of frames per second allowed. The actual number of frames per second may still be below this value if the game is lagging. diff --git a/main/main.cpp b/main/main.cpp index 20270190b3..a11bb904f4 100644 --- a/main/main.cpp +++ b/main/main.cpp @@ -600,7 +600,9 @@ Error Main::setup(const char *execpath, int argc, char *argv[], bool p_second_ph GLOBAL_DEF_RST("application/run/flush_stdout_on_print.debug", true); GLOBAL_DEF("debug/settings/crash_handler/message", - String("Please include this when reporting the bug on https://github.com/godotengine/godot/issues")); + String("Please include this when reporting the bug to the project developer.")); + GLOBAL_DEF("debug/settings/crash_handler/message.editor", + String("Please include this when reporting the bug on: https://github.com/godotengine/godot/issues")); MAIN_PRINT("Main: Parse CMDLine"); -- cgit v1.2.3