From bafcde805ce82ae8dfbd0aec6659b2e4fca163de Mon Sep 17 00:00:00 2001 From: Fabio Alessandrelli Date: Tue, 23 Oct 2018 12:31:47 +0200 Subject: Remove unneeded strncpy in lws_client. Pass the String buffer directly, lws_client_connect_via_info will copy them for us. --- modules/websocket/lws_client.cpp | 28 +++++++++------------------- 1 file changed, 9 insertions(+), 19 deletions(-) diff --git a/modules/websocket/lws_client.cpp b/modules/websocket/lws_client.cpp index add3931b50..d71d091720 100644 --- a/modules/websocket/lws_client.cpp +++ b/modules/websocket/lws_client.cpp @@ -34,10 +34,6 @@ #include "core/io/stream_peer_ssl.h" #include "tls/mbedtls/wrapper/include/openssl/ssl.h" -#if defined(MINGW_ENABLED) || defined(_MSC_VER) -#define strncpy strncpy_s -#endif - Error LWSClient::connect_to_host(String p_host, String p_path, uint16_t p_port, bool p_ssl, PoolVector p_protocols) { ERR_FAIL_COND_V(context != NULL, FAILED); @@ -80,26 +76,11 @@ Error LWSClient::connect_to_host(String p_host, String p_path, uint16_t p_port, ERR_FAIL_V(FAILED); } - char abuf[1024]; - char hbuf[1024]; - char pbuf[2048]; - String addr_str = (String)addr; - strncpy(abuf, addr_str.ascii().get_data(), 1023); - abuf[1023] = '\0'; - strncpy(hbuf, p_host.utf8().get_data(), 1023); - hbuf[1023] = '\0'; - strncpy(pbuf, p_path.utf8().get_data(), 2047); - pbuf[2047] = '\0'; - i.context = context; if (p_protocols.size() > 0) i.protocol = _lws_ref->lws_names; else i.protocol = NULL; - i.address = abuf; - i.host = hbuf; - i.path = pbuf; - i.port = p_port; if (p_ssl) { i.ssl_connection = LCCSCF_USE_SSL; @@ -109,7 +90,16 @@ Error LWSClient::connect_to_host(String p_host, String p_path, uint16_t p_port, i.ssl_connection = 0; } + // This String needs to survive till we call lws_client_connect_via_info + String addr_str = (String)addr; + + i.address = addr_str.ascii().get_data(); + i.host = p_host.utf8().get_data(); + i.path = p_path.utf8().get_data(); + i.port = p_port; + lws_client_connect_via_info(&i); + return OK; }; -- cgit v1.2.3 From e6a069119b2a4721808c7ad39c58a85ea094dfd3 Mon Sep 17 00:00:00 2001 From: Fabio Alessandrelli Date: Tue, 23 Oct 2018 12:49:24 +0200 Subject: Add missing EMWSServer::poll function. Empty of course as server is not supported in HTML5, but the symbol must be defined. --- modules/websocket/emws_server.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/modules/websocket/emws_server.cpp b/modules/websocket/emws_server.cpp index ad4a758c0f..db02162699 100644 --- a/modules/websocket/emws_server.cpp +++ b/modules/websocket/emws_server.cpp @@ -71,6 +71,9 @@ int EMWSServer::get_peer_port(int p_peer_id) const { void EMWSServer::disconnect_peer(int p_peer_id, int p_code, String p_reason) { } +void EMWSServer::poll() { +} + EMWSServer::EMWSServer() { } -- cgit v1.2.3