From 61d70fe47cfaa4efee505c7073aacfe34b66c217 Mon Sep 17 00:00:00 2001 From: Juan Linietsky Date: Sat, 7 Apr 2018 17:04:12 -0300 Subject: Document condition to avoid mistakes (like #17690) --- scene/2d/canvas_item.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scene/2d/canvas_item.cpp b/scene/2d/canvas_item.cpp index 5cca5705a0..918fb1616f 100644 --- a/scene/2d/canvas_item.cpp +++ b/scene/2d/canvas_item.cpp @@ -821,6 +821,12 @@ float CanvasItem::draw_char(const Ref &p_font, const Point2 &p_pos, const void CanvasItem::_notify_transform(CanvasItem *p_node) { + /* This check exists to avoid re-propagating the transform + * notification down the tree on dirty nodes. It provides + * optimization by avoiding redundancy (nodes are dirty, will get the + * notification anyway). + */ + if (/*p_node->xform_change.in_list() &&*/ p_node->global_invalid) { return; //nothing to do } -- cgit v1.2.3