From 4b13a6dcb88c12cf71029c089f5fffb4cd53807a Mon Sep 17 00:00:00 2001 From: Nathan Franke Date: Sun, 24 Jul 2022 03:14:53 -0500 Subject: add equal checks to Transform3D::looking_at and Transform3D::set_look_at --- core/math/transform_3d.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/core/math/transform_3d.cpp b/core/math/transform_3d.cpp index 76b31daa76..44248c274f 100644 --- a/core/math/transform_3d.cpp +++ b/core/math/transform_3d.cpp @@ -70,12 +70,18 @@ void Transform3D::rotate_basis(const Vector3 &p_axis, real_t p_angle) { } Transform3D Transform3D::looking_at(const Vector3 &p_target, const Vector3 &p_up) const { +#ifdef MATH_CHECKS + ERR_FAIL_COND_V_MSG(origin.is_equal_approx(p_target), Transform3D(), "The transform's origin and target can't be equal."); +#endif Transform3D t = *this; t.basis = Basis::looking_at(p_target - origin, p_up); return t; } void Transform3D::set_look_at(const Vector3 &p_eye, const Vector3 &p_target, const Vector3 &p_up) { +#ifdef MATH_CHECKS + ERR_FAIL_COND_MSG(p_eye.is_equal_approx(p_target), "The eye and target vectors can't be equal."); +#endif basis = Basis::looking_at(p_target - p_eye, p_up); origin = p_eye; } -- cgit v1.2.3