| Age | Commit message (Collapse) | Author |
|---|
|
Fix Coverity reports of uninitialized scalar variable
|
|
Fixes logically dead code (Coverity)
|
|
|
|
Fixes reported logically dead codes by Coverity
* image.cpp: Doesn't really need any modification. But to remove the bug
report then we have to move the MAX call away from the for loop
statement.
* rasterizer_gles3.cpp: Removes unnecessary elif condition since it is
checked earlier in the function
* collada.cpp: If stamement never reached due to macro ERR_CONTINUE does
the same.
* navigation_mesh.cpp: Variables should always be null - however, also
checked for the very same condition in their function call. Leaving this
for review (whether the function call is necessary or not)
* path_editor_plugin.cpp: If cancel is true, then it should restore the
edited value to the original provided.
http://docs.godotengine.org/en/3.0/classes/class_editorspatialgizmo.html#class-editorspatialgizmo-commit-handle
* spatial_editor_gizmos.cpp: the very condition of i >= 3 is
predetermined in the if case right before it. Thus case 1 is always '1'
and case 2 is always '-1'
* grid_map_editor.cpp: Same as above in spatial_editor_gizmos.cpp
* voxel_light_baker.cpp: Same as above in spatial_editor_gizmos.cpp
* visual_server.cpp: Same as above in spatial_editor_gizmos.cpp
* visual_script_expression.cpp: char '-' is already true in the switch
case mechanism. Thus it can never reach to default case.
* particles.cpp: Case 'PARAM_MAX' is unreachable due to index checking
right before the switch execution.
* shader_language.cpp: Invalid index is handled in switch default case.
`type < TYPE_FLOAT && type > TYPE_VEC4` -> `(type < TYPE_FLOAT || type > TYPE_VEC4`)
Fixes the "always false problem" in TODO comment.
|
|
Fixes most current reports on Coverity Scan of uninitialized scalar
variable (CWE-457): https://cwe.mitre.org/data/definitions/457.html
These happen most of the time (in our code) when instanciating structs
without a constructor (or with an incomplete one), and later returning
the instance. This is sometimes intended though, as some parameters are
only used in some situations and should not be double-initialized for
performance reasons (e.g. `constant` in ShaderLanguage::Token).
|
|
Fixes canvas light shaders.
|
|
|
|
Fixes #16904
Restore more out functionality, fix built-ins.
Requested changes, I think?
|
|
|
|
Remove disabled shapes from physics 2D calculations
|
|
Fix few bugs in shader definitions
|
|
Changed debug max distance to avoid overflow
|
|
Added new audio device functions to set/get the audio device
|
|
|
|
|
|
Fix compressor audio effect sidechain selection
|
|
A few enhancements on the ARVR Server
|
|
|
|
|
|
Fix crash in `canvas_item_add_polyline` when passing more points than colors
|
|
When `p_points.size() > p_colors.size()`, it crashed with invalid
array access to `p_colors`. Also, when `p_colors` was an empty
`Vector` it crashed due a missing `else` checking the `size`
condition, as the code handling that special case exists.
This PR fixes the missing `else` for `p_colors.size == 0` and,
following the `canvas_item_add_multiline` spirit, it only uses the
first color for the whole polyline if points and colors differ in
size.
Fix #17621.
|
|
|
|
Changed it to roughly sqrt(FLT_MAX), it's a little less to account for float inaccuracies.
Fixes #1835
|
|
AudioServer emit bus_layout_changed signal when adding, moving or del…
|
|
Apply culling margin (fixes issue #16115)
|
|
|
|
|
|
Deprecated Godot 3D physics engine
|
|
Fix invalid mix function overload
|
|
RasterizerGLES3
|
|
|
|
|
|
Make the shader token names consistent.
|
|
|
|
|
|
Disabling a shape removes it from physics calculations. Enabling a shape adds it back to the physics calculations.
|
|
to actually apply extra culling margin and mark instance AABB dirty
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Found via `codespell -q 3 --skip="./thirdparty,./editor/translations" -I ../godot-word-whitelist.txt`
Whitelist consists of:
```
ang
doubleclick
lod
nd
que
te
unselect
```
|
|
|
|
Improved kinematic body, Now can move rigid body
|
|
|
|
|
|
Handle single-argument constructors in uniform default values
|
|
Improved ray shape (2D and 3D) by addiing the possibility to act as r…
|