Age | Commit message (Collapse) | Author |
|
Fix vector reduction in shader language
|
|
|
|
Fixes logically dead code (Coverity)
|
|
|
|
Fixes reported logically dead codes by Coverity
* image.cpp: Doesn't really need any modification. But to remove the bug
report then we have to move the MAX call away from the for loop
statement.
* rasterizer_gles3.cpp: Removes unnecessary elif condition since it is
checked earlier in the function
* collada.cpp: If stamement never reached due to macro ERR_CONTINUE does
the same.
* navigation_mesh.cpp: Variables should always be null - however, also
checked for the very same condition in their function call. Leaving this
for review (whether the function call is necessary or not)
* path_editor_plugin.cpp: If cancel is true, then it should restore the
edited value to the original provided.
http://docs.godotengine.org/en/3.0/classes/class_editorspatialgizmo.html#class-editorspatialgizmo-commit-handle
* spatial_editor_gizmos.cpp: the very condition of i >= 3 is
predetermined in the if case right before it. Thus case 1 is always '1'
and case 2 is always '-1'
* grid_map_editor.cpp: Same as above in spatial_editor_gizmos.cpp
* voxel_light_baker.cpp: Same as above in spatial_editor_gizmos.cpp
* visual_server.cpp: Same as above in spatial_editor_gizmos.cpp
* visual_script_expression.cpp: char '-' is already true in the switch
case mechanism. Thus it can never reach to default case.
* particles.cpp: Case 'PARAM_MAX' is unreachable due to index checking
right before the switch execution.
* shader_language.cpp: Invalid index is handled in switch default case.
`type < TYPE_FLOAT && type > TYPE_VEC4` -> `(type < TYPE_FLOAT || type > TYPE_VEC4`)
Fixes the "always false problem" in TODO comment.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Handle single-argument constructors in uniform default values
|
|
|
|
Expand these (fill vectors, fill matrix diagonals) in _reduce_expression() so they're handled properly even as uniform default values (where they previously caused a crash).
|
|
Using `misc/scripts/fix_headers.py` on all Godot files.
Some missing header guards were added, and the header inclusion order
was fixed in the Bullet module.
|
|
|
|
Happy new year to the wonderful Godot community!
|
|
fixes #15167
|
|
|
|
|
|
#14629
|
|
|
|
Ammend: Removed whitespace from blank lines.
Ammend2: Removed extra spaces in an attempt to make Clang happy. :)
|
|
wrong function,
leading to unnecesary copy on writes and reduced performance.
|
|
is in GLSL.
Fixes #13214.
|
|
...that would happen if incorrect syntax was found just after an opening square bracket.
Fixes #12046.
|
|
|
|
"discard" has been added to the list of recognised keywords.
A flag specifing when discarding is allowed is now set correctly.
|
|
|
|
The forth in my quest to make Godot 3.x compile with -Werror on GCC7
|
|
|
|
|
|
The second in my quest to make Godot 3.x compile with -Werror on GCC7
|
|
|
|
|
|
instruction, fixes #9677
|
|
|
|
|
|
|
|
Fixes #10399.
|
|
-Some fixes to shader lang
|
|
make it more GLSL compatible
-Fixed referencing of world_transform in fragment shader not working
-Fixed unsycn bug related to getting shader param list from the server
-Fixed getting all textures from shader properly, fixes #8353
|
|
|
|
|
|
|
|
|
|
From https://github.com/lucasdemarchi/codespell
|
|
I can show you the code
Pretty, with proper whitespace
Tell me, coder, now when did
You last write readable code?
I can open your eyes
Make you see your bad indent
Force you to respect the style
The core devs agreed upon
A whole new world
A new fantastic code format
A de facto standard
With some sugar
Enforced with clang-format
A whole new world
A dazzling style we all dreamed of
And when we read it through
It's crystal clear
That now we're in a whole new world of code
|
|
- Add FIXME tags comments to some unfixed potential bugs
- Remove some checks (always false: unsigned never < 0)
- Fix some if statements based on reviews.
- Bunch of missing `else` statements
|