summaryrefslogtreecommitdiff
path: root/scene/gui
AgeCommit message (Collapse)Author
2020-05-16Fix Container sorting not working when overriding _sort_children in gdscriptPouleyKetchoupp
Remove _sort_children from script bindings: _sort_children is an internal method which shouldn't be exposed to scripts. Added support for non-bound methods in MessageQueue: So we can use deferred calls without exposing internal methods to scripts. Added debug checks in CallableCustomMethodPointer: Adding method pointer callables to the message queue was causing crashes in case an object was destroyed and the same memory was allocated for another one. The new object had a valid object id but the call was erroneous. Release will be fixed later, along with Variant which has the same problem and is also fixed for debug only.
2020-05-14Style: Enforce braces around if blocks and loopsRémi Verschelde
Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14Style: Enforce separation line between function definitionsRémi Verschelde
I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocksRémi Verschelde
Which means that reduz' beloved style which we all became used to will now be changed automatically to remove the first empty line. This makes us lean closer to 1TBS (the one true brace style) instead of hybridating it with some Allman-inspired spacing. There's still the case of braces around single-statement blocks that needs to be addressed (but clang-format can't help with that, but clang-tidy may if we agree about it). Part of #33027.
2020-05-14Modernize remaining uses of 0/NULL instead of nullptr (C++11)Rémi Verschelde
Using clang-tidy's `modernize-use-nullptr`. https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-nullptr.html
2020-05-14Port member initialization from constructor to declaration (C++11)Rémi Verschelde
Using `clang-tidy`'s `modernize-use-default-member-init` check and manual review of the changes, and some extra manual changes that `clang-tidy` failed to do. Also went manually through all of `core` to find occurrences that `clang-tidy` couldn't handle, especially all initializations done in a constructor without using initializer lists.
2020-05-12Merge pull request #38655 from ↵Rémi Verschelde
ice-blaze/minimap-shifted-selection-by-one-line#38532 Fix minimap selection offset
2020-05-11Using the common behaviour when use command+shift on text line for osxEduardo Nunes Pereira
* On press left+command+shift or right+command+shift it should behave like shift+home or shift+end and select the text * Using home and end events as reference
2020-05-11Fix minimap selection offsetetienne.frank
The minimap selection was shifted of 1 line too late.
2020-05-10Style: clang-format: Disable AllowShortCaseLabelsOnASingleLineRémi Verschelde
Part of #33027.
2020-05-10Style: clang-format: Disable AllowShortIfStatementsOnASingleLineRémi Verschelde
Part of #33027, also discussed in #29848. Enforcing the use of brackets even on single line statements would be preferred, but `clang-format` doesn't have this functionality yet.
2020-05-10Style: Add missing copyright headersRémi Verschelde
2020-05-07Merge pull request #31086 from volzhs/underlineRémi Verschelde
Use underline position and thickness value in font file
2020-05-07Merge pull request #38385 from ThakeeNathees/method-bind-text_edit-set_lineRémi Verschelde
method bind TextEdit::set_line() added
2020-05-06PopupMenu.get_current_index() bound to ClassDBnobuyuki_nyuu
2020-05-06Merge pull request #38495 from DarkMessiah/tree-bind-suffixRémi Verschelde
Bind set_suffix and get_suffix in Tree
2020-05-06Merge pull request #38488 from ↵Rémi Verschelde
EricEzaM/adjust-stretch-ratio-value-range-and-documentation Updated editor spin slider to have better behaviour and adjusted control's size_flags_stretch_ratio value range
2020-05-06Bind set_suffix/get_suffix in TreeStanislav Labzyuk
2020-05-06Updated editor spin slider to have better behaviour and adjusted control's ↵Eric M
size_flags_stretch_ratio value range
2020-05-05Merge pull request #37293 from Janglee123/ctrl-click-improvementsRémi Verschelde
Improved go-to definition (Ctrl + Click)
2020-05-05Improved go-to definition (Ctrl + Click)janglee
Co-Authored-By: Bojidar Marinov <bojidar.marinov.bg@gmail.com>
2020-05-01method bind TextEdit::set_line() addedThakee Nathees
2020-04-30Fixed bbcode parsing for built-in RichTextEffects in RichTextLabelDarenn
RichTextEffect can now have a bbcode string starting like one of the built-in. It was impossible before as the built-in would take precedence over the custom effect that has the same bbcode start. Example : [fade] would take precedence over [fade_in]
2020-04-29Merge pull request #37846 from CaptainProton42/text-edit-undo-stack-sizeRémi Verschelde
Add "undo_max_stack_size" property to TextEdit
2020-04-29Use underline position and thickness value in font filevolzhs
2020-04-29Limit undo stack sizeJohn Wigg
The stack size of the undo history of a TextEdit was not limited leading to potential memory leaks when doing lots of operations on a TextEdit. This commit adds the option gui/common/text_edit_undo_stack_max_size to the project settings. The first element of the undo stack is popped if the stack's size exceeds this value ensuring limited memory usage. The default stack size setting is 1024. Fixes #37838.
2020-04-29[Core] Rename linear_interpolate to lerpAaron Franke
2020-04-29Remove unneccessary increment in TextEditTomasz Chabora
2020-04-28Rename InputFilter back to InputRémi Verschelde
It changed name as part of the DisplayServer and input refactoring in #37317, with the rationale that input no longer goes through the main loop, so the previous Input singleton now only does filtering. But the gains in consistency are quite limited in the renaming, and it breaks compatibility for all scripts and tutorials that access the Input singleton via the scripting language. A temporary option was suggested to keep the scripting singleton named `Input` even if its type is `InputFilter`, but that adds inconsistency and breaks C#. Fixes godotengine/godot-proposals#639. Fixes #37319. Fixes #37690.
2020-04-16Merge pull request #37047 from YeldhamDev/tabcontainer_doc_control_fixRémi Verschelde
Fix incorrect TabContainer documentation for 'get_tab_control()'
2020-04-15Add "node_unselected" signal for GraphEditasheraryam
2020-04-13Fixed 0 width issue of rich text labeljanglee
Fixes #37746
2020-04-10Fix OptionButton docs godotengine#36803Zak Grumbles
* item_selected and item_focused docs incorrectly had 'id' as the parameter. Changed to 'index'. * Fix parameter name in ADD_SIGNAL callin code.
2020-04-10Merge pull request #37517 from nekomatata/slider-grab-area-highlightRémi Verschelde
Add style for highlighted Slider grab area
2020-04-08Remove unused ofs variabletheludovyc
2020-04-08erase : if ( i < offset ) { continue;} in for loopstheludovyc
2020-04-07Fixed underlines and striketrough not respecting visible characterjanglee
2020-04-07Merge pull request #37591 from Anutrix/remove_reduntant_classRémi Verschelde
Removed redundant class LineEditFileChooser from file_dialog
2020-04-07Merge pull request #37642 from dreamsComeTrue/rich-text-strike-fixRémi Verschelde
Calculate strike-through y-position correctly (RichTexteLabel)
2020-04-07Merge pull request #37615 from guilhermefelipecgs/fix_37526Rémi Verschelde
Fix TextureRect::flip_* when used with atlas texture
2020-04-06Calculate strike-through position correctlyDominik 'dreamsComeTrue' Jasiński
Fixes: #37637
2020-04-06Merge pull request #37639 from qarmin/no_more_leaksRémi Verschelde
Fixes leaks when running editor
2020-04-06Fixes leaks when running editorqarmin
2020-04-06Fix TextureRect::flip_* when used with atlas textureGuilherme Felipe
Fix #37526
2020-04-06Merge pull request #37556 from KoBeWi/kill_get_indexRémi Verschelde
Remove Node.get_position_in_parent()
2020-04-06Remove Node.get_position_in_parent()Tomasz Chabora
2020-04-05Merge pull request #37397 from Eoin-ONeill-Yokai/Bug37081Rémi Verschelde
Correction to RichTextLabel Tabulation (Bug 37081)
2020-04-05Removed reduntant class LineEditFileChooser.unknown
2020-04-04Fix file dialog not showing iconsunknown
2020-04-04Remove redundant vbx variable in FileDialogunknown