summaryrefslogtreecommitdiff
path: root/scene/gui/base_button.cpp
AgeCommit message (Collapse)Author
2023-01-25Add more sections to Button and BaseButtonVolTer
2023-01-21Fix constant editor redraw after shortcutJuan Linietsky
Introduced by me by mistake on #71328. Fixes #71652.
2023-01-13Button shortcuts no longer "press" the Button.Juan Linietsky
* Button shortcuts were treated as generic input events on buttons. This means that to activate a button shortcut you had to press and release. * This logic is removed and now shortcuts always activate on press. * This makes the editor feel more responsive and solves problems related to this behavior. Fixes #45033 and possibly others.
2023-01-08Use BitField<> in core type masksJuan Linietsky
* All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-05One Copyright Update to rule them allRémi Verschelde
As many open source projects have started doing it, we're removing the current year from the copyright notice, so that we don't need to bump it every year. It seems like only the first year of publication is technically relevant for copyright notices, and even that seems to be something that many companies stopped listing altogether (in a version controlled codebase, the commits are a much better source of date of publication than a hardcoded copyright statement). We also now list Godot Engine contributors first as we're collectively the current maintainers of the project, and we clarify that the "exclusive" copyright of the co-founders covers the timespan before opensourcing (their further contributions are included as part of Godot Engine contributors). Also fixed "cf." Frenchism - it's meant as "refer to / see".
2022-12-22Add configuration warning when ButtonGroup is used with non-toggleable buttonsMarkus Sauermann
Also fix ambiguous documentation of ButtonGroup.
2022-11-04Merge pull request #68097 from KoBeWi/no_signal🔕Rémi Verschelde
Add `set_value_no_signal()` to Range
2022-10-31Add set_value_no_signal() to Rangekobewi
2022-10-20Make `BaseButton` Shortcut feedback togglableGeorge L. Albany
2022-10-13Merge pull request #66337 from EricEzaM/sprite-framesRémi Verschelde
Ensure control built-in shortcuts are matched exactly & add shortcuts for SpriteFrames editor
2022-10-13Move Shortcut Context to Control and ensure that `shortcut_input` adheres to ↵Eric M
contexts. Also ensure that controls with no context are only triggered AFTER nodes which do have a context.
2022-09-28Fix MSVC warning C4702: unreachable codeRémi Verschelde
Part of #66537.
2022-09-24Ensure all checks of `is_action` in the editor which are for 'shortcut' use, ↵Eric M
check the action exactly.
2022-09-19Fix #66062: editing shortcut_context in inspectorRedMser
2022-08-29Rename `CanvasItem.update()` to `queue_redraw()`Micky
Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-28Fix some corner cases in the `Menu/OptionButton` item auto-highlightMichael Alexsander
2022-08-24Merge pull request #64635 from YeldhamDev/menu_buttons_popup_fixRémi Verschelde
Make `Menu/OptionButton` item auto-highlight behave better
2022-08-22Replace Array return types with TypedArraykobewi
2022-08-19Make `Menu/OptionButton` item auto-highlight behave betterMichael Alexsander
2022-05-19Use range iterators for RBSet in most casesAaron Record
2022-05-16Replace most uses of Map by HashMapreduz
* Map is unnecessary and inefficient in almost every case. * Replaced by the new HashMap. * Renamed Map to RBMap and Set to RBSet for cases that still make sense (order matters) but use is discouraged. There were very few cases where replacing by HashMap was undesired because keeping the key order was intended. I tried to keep those (as RBMap) as much as possible, but might have missed some. Review appreciated!
2022-04-05[Input] Add extra `shortcut_input` input processing step to process Unicode ↵bruvzg
character input with Alt / Ctrl modifiers, after processing of shortcuts.
2022-03-07Fix typo in BaseButton shortcut context methodsHugo Locurcio
2022-02-15Use `switch` consistently in `_notification` (`scene` folder)Rémi Verschelde
2022-02-03Remove get_focus_owner() from Control, replaced by ↵Gilles Roudière
get_viewport()->gui_get_focus_owner()
2022-01-28Improve some signal bindings to use specific `Object` subtypesRémi Verschelde
2022-01-25Allow unsetting `shortcut_context`.bruvzg
2022-01-23BaseButton: Rename `pressed` property to `button_pressed`Rémi Verschelde
This fixes a conflict with the `pressed` signal. The new name is temporary and only intended to solve the conflict for upcoming alpha builds. Discussions are still ongoing regarding the BaseButton API and how to rename and refactor more of its properties, signals and methods to have a clearer API in 4.0.
2022-01-03Update copyright statements to 2022Rémi Verschelde
Happy new year to the wonderful Godot community!
2021-12-21Fix BaseButton's localization for tooltip with shortcutZae
2021-12-09Replace String comparisons with "", String() to is_empty()Nathan Franke
Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-11-12Use "enum class" for input enumsAaron Franke
2021-08-23Entirely removes BIND_VMETHOD in favor of GDVIRTUALreduz
* `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22Replace BIND_VMETHOD by new GDVIRTUAL syntaxreduz
* New syntax is type safe. * New syntax allows for type safe virtuals in native extensions. * New syntax permits extremely fast calling. Note: Everything was replaced where possible except for `_gui_input` `_input` and `_unhandled_input`. These will require API rework on a separate PR as they work different than the rest of the functions. Added a new method flag METHOD_FLAG_OBJECT_CORE, used internally. Allows to not dump the core virtuals like `_notification` to the json API, since each language will implement those as it is best fits.
2021-08-15command palette improvementsBhuvan Vemula
2021-08-09Added EditorCommandPaletteBhuvan Vemula
2021-08-05Shortcut: Rename `shortcut` property to `event`Rémi Verschelde
Having a property which has the same name as its class leads to confusing situations (e.g. `BaseButton` has a `shortcut` property of type `Shortcut` which has a `shortcut` property of type `InputEvent`). Also renames `is_event` to `matches_event`, and `is_valid` to `has_valid_event` to better reflect what the methods check.
2021-07-18Optimize StringName usagereduz
* Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-13Add set_pressed_no_signal method to BaseButtonkobewi
2021-06-21Rename `is_a_parent_of()` to `is_ancestor_of()`Lightning_A
2021-06-09Merge pull request #49155 from ↵Rémi Verschelde
winterpixelgames/button-pressed-during-button-up-signal Emit button_up signal after setting pressed to false.
2021-06-09Merge pull request #47280 from winterpixelgames/focus_doesnt_change_hoverRémi Verschelde
Dont Change Hovering during Control Focus Events
2021-05-27Emit button_up signal after setting pressed to false.Jason Knight
2021-05-06Adds a pressed signal to ButtonGroupGilles Roudière
2021-04-05Fix crashes in *_input functionsRafał Mikrut
2021-03-22Removed the alteration of status.hovering during Focus Enter and Focus Exit ↵Jason Knight
events. This is incorrect and not fully implemented, and results in inconsistency in the UI and in the hovering variable.
2021-02-10Removed _change_notifyreduz
-For inspector refresh, the inspector now detects if a property change by polling a few times per second and then does update the control if so. This process is very cheap. -For property list refresh, a new signal (property_list_changed) was added to Object. _change_notify() is replaced by notify_property_list_changed() -Changed all objects using the old method to the signal, or just deleted the calls to _change_notify(<property>) since they are unnecesary now.
2021-02-09Initialize class variables with default values in scene/ [2/2]Rafał Mikrut
2021-01-01Update copyright statements to 2021Rémi Verschelde
Happy new year to the wonderful Godot community! 2020 has been a tough year for most of us personally, but a good year for Godot development nonetheless with a huge amount of work done towards Godot 4.0 and great improvements backported to the long-lived 3.2 branch. We've had close to 400 contributors to engine code this year, authoring near 7,000 commit! (And that's only for the `master` branch and for the engine code, there's a lot more when counting docs, demos and other first-party repos.) Here's to a great year 2021 for all Godot users 🎆
2020-11-30Exposed shortcut_context property to scripting and added documentation.Eric M
I didn't expose this as a property or add documentation in the original PR #42109.