| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Change some code proposed by Coverity and Cppcheck
|
|
|
|
Use is_zero_approx(), avoid a negative, and also rename "rng" to "range".
|
|
|
|
These silently fail, so they should be removed. I accidentally added most of these last year, trying to make everything else consistent with Quat, sorry!
Also, a few tiny nitpicking changes are included, like whitespace and misspellings.
|
|
|
|
Mono: Fix custom defines for Mono's MSBuild; remove xbuild
|
|
Mono's MSBuild and System/VisualStudio's MSBuild expect a different format for surrounding property values with quotes on the command line.
xbuild does not seem to support semicolons in property values from the command line: https://xamarin.github.io/bugzilla-archives/16/16465/bug.html
It's a good time to just remove xbuild support entirely.
|
|
Fix incorrectly updating csproj and not closing build issues file
|
|
|
|
Previously, when running the project manager, we would try to load the API assemblies from the project and fail because we were not editing any project. This would make us try to copy the prebuilt API assemblies to the project. Since there is no project, it would try to copy them to the executable location. This would fail if Godot doesn't have permissions to write to that location.
This commit fixes that by instead trying to load the prebuilt API assemblies in the first place, if running the project manager.
|
|
|
|
By default, an unhandled exception will cause the application to be terminated; but the project setting `mono/unhandled_exception_policy` was added to change this behaviour.
The editor is hard-coded to never terminate because of unhandled exceptions, as that would make writing editor plugins a painful task, and we cannot kill the editor because of a mistake in a thirdparty plugin.
|
|
|
|
If both the core and editor API assemblies are missing or out of sync, Godot will only update the former and then abort when trying to load them again because the latter was not updated. Godot will update it correctly the next time it's started, but this should not be needed and it should work the first time. This commit fixes that.
|
|
Fix mono module build errors for release templates
|
|
|
|
Co-authored-by: Xrayez <https://github.com/Xrayez>
Co-authored-by: DleanJeans <https://github.com/DleanJeans>
|
|
Mono: Better handling of missing/outdated API assemblies
|
|
Remove the old API assembly invalidation system. It's pretty simple since now the editor has a hard dependency on the API assemblies and SCons takes care of prebuilding them.
If we fail to load a project's API assembly because it was either missing or outdated, we just copy the prebuilt assemblies to the project and try again. We also do this when creating the solution and before building, just in case the user removed them from the disk after they were loaded.
This way the API assemblies will be always loaded successfully. If they are not, it's a bug.
Also fixed:
- EditorDef was behaving like GlobalDef in GodotTools.
- NullReferenceException because we can't serialize System.WeakReference yet. Use Godot.WeakRef in the mean time.
|
|
|
|
|
|
Mono: Fix Api HintPath and update old game projects
|
|
Mono: Fix null dereference in EditorExportPlatformAndroid
|
|
Fixed Api assembly references with more than one HintPath.
Also made the editor update old C# projects use the new Api assembly HintPaths.
|
|
We need to dispose the GodotSharpExport export plugin before the editor destroys EditorSettings. Otherwise, if the GC disposes it at a later time, EditorExportPlatformAndroid will be freed after EditorSettings already was, and its device polling thread will try to access the EditorSettings singleton, resulting in null dereferencing.
|
|
Fix IndexOutOfBounds in FindMsBuildToolsPathOnWindows
|
|
Mono: Fix null exception in GenerateGameProject
|
|
Also fix pdb files for GodotTools.*.dll assemblies not being copied to the output directory.
|
|
SCons no longer passes FrameworkPathOverride to MSBuild
|
|
|
|
|
|
|
|
Also added an option to output a json file with all the ClassDB registered classes and its members. This can be used to compare the API of two different builds by a simple diff.
|
|
Fix export templates ignoring assemblies in 'res://.mono/assemblies'
|
|
|
|
|
|
Misc Mono Fixes
|
|
|
|
|
|
Should not be using Variant to String conversion as that would call ToString() again
|
|
DirAccess::get_full_path(path) only works if the path exists. Implement our own abspath function.
|
|
ClassDB::can_instance was changed recently breaking our code, as the editor is not yet initialized. Check ClassInfo::creation_func directly.
|
|
Old value wasn't string so we have to keep that in mind
|
|
|
|
ptrcall assumes methods that return a Reference type do so with Ref<T>. Returning Reference* from a method exposed to the scripting API completely breaks ptrcalls to this method (it can be quite hard to debug!).
|
|
Make the build system automatically build the C# Api assemblies to be shipped with the editor.
Make the editor, editor player and debug export templates use Api assemblies built with debug symbols.
Always run MSBuild to build the editor tools and Api assemblies when building Godot.
Several bugs fixed related to assembly hot reloading and restoring state.
Fix StringExtensions internal calls not being registered correctly, resulting in MissingMethodException.
|
|
Mono: Fix Array IndexOutOfRangeException not being thrown
|
|
Mono: Android build and shared libraries fixes
|