summaryrefslogtreecommitdiff
path: root/modules/mono
AgeCommit message (Collapse)Author
2020-01-24Merge pull request #35527 from neikeq/issue-35259Rémi Verschelde
Mono/C#: Fix _update_exports possible crash with Reference types
2020-01-24Merge pull request #35524 from neikeq/issue-35496Rémi Verschelde
Fix C# preprocessor infinite loop and incorrect parsing of `#if!`
2020-01-24Mono/C#: Fix _update_exports possible crash with Reference typesIgnacio Etcheverry
The code was attempting to dynamic cast the native instance to Reference after the managed instance was disposed. As the managed instance acts as a Ref, the native instance was freed during that disposal. This made the dynamic cast fail and we attempted to memdelete a second time. The fix is to make the dynamic cast before disposal.
2020-01-24Fix C# preprocessor infinite loop and incorrect parsing of `#if!`Ignacio Etcheverry
2020-01-23Merge pull request #35491 from neikeq/issue-35450Rémi Verschelde
Mono/C#: Lighten up unsafe reference checks
2020-01-23Mono/C#: Lighten up unsafe reference checksIgnacio Etcheverry
Because of the weird case with multi-threading and ResourceLoader, it can be the case that a resource is GCed while being referenced again in the main thread. In such cases, a new unsafe reference is created before the finalizer thread removes the previous one.
2020-01-23Merge pull request #35478 from neikeq/issue-32260Rémi Verschelde
Mono/C#: Add setting to include I18N assemblies in the exported game
2020-01-23Mono/C#: Add setting to include I18N assemblies in the exported gameIgnacio Etcheverry
2020-01-23Merge pull request #35473 from neikeq/default-to-net47Rémi Verschelde
Mono/C#: Default to net47 for new projects
2020-01-23Mono/C#: Add Basis.Slerp, update Quat.Xform and add some math checksIgnacio Etcheverry
2020-01-23Mono/C#: Default to net47 for new projectsIgnacio Etcheverry
2020-01-21Make script class parser errors to not abort the buildIgnacio Etcheverry
As our script class parser is error prone, we should not impede the build from continuing because of a parsing error. This should be reverted in the future once we switch to Roslyn.
2020-01-21Add dummy preprocessor for the C# script class parserIgnacio Etcheverry
No attempts are made at conditional compilation. The main if branch is always assumed to be true.
2020-01-20Mono/C#: Fix error when parsing nested genericsIgnacio Etcheverry
Also fixed the editor not including the parse error message in the error.
2020-01-19Fix ClassDB API portability with some android and editor classesIgnacio Etcheverry
- `EditorNavigationMeshGenerator` was being registered as part of the Core API, even after d3f48f88bb84d22b7805ce971ac86cf1953a29fd. We must make sure to set Editor as the current ClassDB API type before creating an instance. - The `VisualScriptEngineSingleton.constant` property has a property hint string that's different between tools and non-tools builds. This commit makes the hint string to no longer be set in `_bind_methods`, and to instead set it in `_validate_property`. This way it's ignored when calculating the API hash. - `JavaClassWrapper` is now registered in ClassDB on all platforms, using a dummy implementation on platforms other than Android. This fixes API portability between Android and other platforms. - Updated `--class-db-json` command to ignore non-virtual methods that start with an underscore (see: 4be87c6016a5893cbde897924e540df4c988cee5).
2020-01-16Merge pull request #35208 from neikeq/mono-lazy-thread-attachIgnacio Roldán Etcheverry
Mono/C#: Script interface calls now attach the current thread
2020-01-16Mono/C#: Script interface calls now attach the current threadIgnacio Etcheverry
Added guards to all C# script interface calls to attach the current thread for the current scope if the thread is not already attached. This is far from ideal, as attaching the thread is not cheap and all managed thread local storage is lost when we detach the thread at the end of the calls. However, it's the best we can do for now to avoid crashing when an unattached thread tries to interact with C# code.
2020-01-15Mono/C#: Fix false positive in unsafe reference checksIgnacio Etcheverry
2020-01-15Mono: Fix parsing assembly names as UTF-8Rémi Verschelde
Fixes #27185.
2020-01-13Mono/C#: Add error checks to detect possible Reference leaksIgnacio Etcheverry
2020-01-13Mono/C#: Fix _update_exports() leaking temporary Object/Node instancesIgnacio Etcheverry
2020-01-03[Mono]: the C# script icon is now visible in the editor.dankan1890
2020-01-03Merge pull request #34784 from neikeq/fix-hintpath-godottoolsRémi Verschelde
Mono/C#: Fix wrong HintPath for package in GodotTools
2020-01-03Mono/C#: Fix wrong HintPath for package in GodotToolsIgnacio Etcheverry
2020-01-03[Mono] Color arithmetic operatorsAaron Franke
2020-01-02[Mono] Make Sign methods consistent with GDScript and System.MathAaron Franke
2020-01-02Mono/C#: Fix comment generation for non-constant param defaultIgnacio Etcheverry
- Generate the comment for the param, even if the method has no description. - Generate the comment outside the <summary> element.
2020-01-02Mono/C#: Fix bindings generator with void vararg methodsIgnacio Etcheverry
Commit 4d727f1ee6b970298a7c1752ba19b49d7060c405 made it possible for vararg methods to return void. This broke the C# bindings generator which was assuming in one place that vararg methods always return Variant.
2020-01-02Mono/C#: Make 'GD.Print' and its variants fallback to 'ToString()'Ignacio Etcheverry
Up until now, 'GD.Print' would convert parameters first to Variant and only then to String. This meant parameters that cannot be converted to Variant would be printed as "Null". This commit makes 'GD.Print' fallback to 'System.Object.ToString()' if the parameter could not be converted to Variant. The same applies to all 'GD.Print' variants: 'GD.PrintS', 'GD.PrintT', 'GD.PrintErr' and 'GD.PrintRaw'.
2020-01-02Mono/C#: Fix GD.PrintErr now showing in the Output panelIgnacio Etcheverry
2020-01-01Update copyright statements to 2020Rémi Verschelde
Happy new year to the wonderful Godot community! We're starting a new decade with a well-established, non-profit, free and open source game engine, and tons of further improvements in the pipeline from hundreds of contributors. Godot will keep getting better, and we're looking forward to all the games that the community will keep developing and releasing with it.
2019-12-31Merge pull request #34699 from van800/godot-guidIgnacio Roldán Etcheverry
Custom property for Godot generated project
2019-12-30Merge pull request #34582 from timothyqiu/forward-declRémi Verschelde
Cleans up headers included in editor_node.h
2019-12-30add custom property to csproj, which identifies that project is generated by ↵Ivan Shakhov
Godot
2019-12-29Fix msbuild target argumentDan Kramer
2019-12-28Mono/C#: Re-structure API solution and GodotTools post-build targetIgnacio Etcheverry
Previously we had a placeholder solution called 'Managed' to benefit from tooling while editing the a part of the C# API. Later the bindings generator would create the final 'GodotSharp' solution including these C# files as well as the auto-generated C# API. Now we replaced the 'Managed' solution with the final 'GodotSharp' solution which is no longer auto-generated, and the bindings generator only takes care of the auto-generated C# API. This has the following benefits: - It's less confusing as there will no longer be two versions of the same file (the original and a generated copy of it). Now there's only one. - We no longer need placeholder for auto-generated API classes, like Node or Resource. We used them for benefiting from tooling. Now we can just use the auto-generated API itself. - Simplifies the build system and bindings generator. Removed lot of code that is not needed anymore. Also added a post-build target to the GodotTools project to copy the output to the data dir. This makes it easy to iterate when doing changes to GodotTools, as SCons doesn't have to be executed anymore just to copy these new files.
2019-12-26Merge pull request #34595 from van800/mac_riderIgnacio Roldán Etcheverry
Fix search for Rider path on Mac
2019-12-25Merge pull request #34604 from neikeq/issue-27674Ignacio Roldán Etcheverry
Mono/C#: Fix memory leak with new Reference instances created from C#
2019-12-25Mono/C#: Fix memory leak with new Reference instances created from C#Ignacio Etcheverry
2019-12-25fix Rider path on MacIvan.Shakhov
2019-12-24Cleans up headers included in editor_node.hHaoyu Qiu
2019-12-21add suggested fixDan Kramer
2019-12-21Merge pull request #34514 from neikeq/remove-dep-on-mono-posixRémi Verschelde
Mono/C#: Remove GodotTools dependency on the Mono.Posix assembly
2019-12-21Mono/C#: Remove GodotTools dependency on the Mono.Posix assemblyIgnacio Etcheverry
MSBuild on Windows uses the system .NET Framework BCL instead of Mono's. Because of this, it may not be able to find the Mono.Posix assembly, so it's better not to depend on it. We needed Mono.Posix to call Syscall.access, so we can replace this with an internal call that does the same in C++.
2019-12-19Merge pull request #34465 from neikeq/no-hardcode-debugger-waitRémi Verschelde
Mono/C#: Remove hard-coded debugger wait at initialization
2019-12-19Mono/C#: Remove hard-coded debugger wait at initializationIgnacio Etcheverry
Up until now debug builds would always wait up to 500 ms during initialization to give time for debuggers to attach to the game. We no longer want this as it increases startup time unnecesarily. The way forward is to setup the debugger agent as client instead of server. This way it's the game that connect to the debugger, not the other way around. If server mode is still desired, suspend=y can be used to indefinitely wait for the debugger to attach. This all can be specified with the environment variable 'GODOT_MONO_DEBUGGER_AGENT' when launching the game.
2019-12-19Mono/C#: Fix Variant -> MonoString* when type is Variant:NILIgnacio Etcheverry
`Variant::operator String()` returns "Null" if the type is `Variant:NIL`. We must consider that and return a null `MonoString*` instead when marshalling. This was also causing a "Null" error to be displayed when exporting a game because null string members would be set to "Null" during hot-reload.
2019-12-18Mono: Copy native and btls libs on macOSRémi Verschelde
2019-12-17Mono/C#: Fix project export and fix FindLast/GetFile regressionIgnacio Etcheverry
d09193b08ae8fdb082bee6ffd3828eb19fd45ce6 introduced a regression in StringExtensions.FindLast. StringExtensions.GetFile was also affected as it relies on FindLast. This in turn broke the project exporter as it uses GetFile. The cause of the regression is that now FindLast is calling LastIndexOf with 'startIndex: 0'. This should be 'startIndex: str.Length - 1' instead. Also fixed another regression in the project exporter: de7c2ad21b4cc2d889a5aeda64ead962036d2aa4 moved 'GodotTools/GodotSharpExport.cs' to 'GodotTools/Export/ExportPlugin.cs' and in doing so accidently reverted the changes from commit e439581198de92e63661c4fe71108cb59cc2d999.
2019-12-16Merge pull request #34382 from van800/profilerRémi Verschelde
Allow attaching any external profiler, including JetBrains dotTrace