Age | Commit message (Collapse) | Author | |
---|---|---|---|
2022-08-29 | Revert "Remove NOTIFICATION_ENTER_TREE when paired with ↵ | Rémi Verschelde | |
NOTIFICATION_THEME_CHANGED" This reverts commit 4b817a565cab8af648c88cfc7ab6481e86ee3625. Fixes #64988. Fixes #64997. This caused several regressions (#64988, #64997, https://github.com/godotengine/godot/issues/64997#issuecomment-1229970605) which point at a flaw in the current logic: - `Control::NOTIFICATION_ENTER_TREE` triggers a *deferred* notification with `NOTIFCATION_THEME_CHANGED` as introduced in #62845. - Some classes use their `THEME_CHANGED` to cache theme items in member variables (e.g. `style_normal`, etc.), and use those member variables in `ENTER_TREE`, `READY`, `DRAW`, etc. Since the `THEME_CHANGE` notification is now deferred, they end up accessing invalid state and this can lead to not applying theme properly (e.g. for EditorHelp) or crashing (e.g. for EditorLog or CodeEdit). So we need to go back to the drawing board and see if `THEME_CHANGED` can be called earlier so that the previous logic still works? Or can we refactor all engine code to make sure that: - `ENTER_TREE` and similar do not depend on theme properties cached in member variables. - Or `THEME_CHANGE` does trigger a general UI update to make sure that any bad theme handling in `ENTER_TREE` and co. gets fixed when `THEME_CHANGE` does arrive for the first time. But that means having a temporary invalid (and possibly still crashing) state, and doing some computations twice which might be heavy (e.g. `EditorHelp::_update_doc()`). | |||
2022-08-27 | Remove NOTIFICATION_ENTER_TREE when paired with NOTIFICATION_THEME_CHANGED | Aaron Record | |
2022-08-22 | Add per-scene UndoRedo | kobewi | |
2022-08-20 | Expose Basis `set_orthogonal_index` method as a GridMap function | rafallus | |
2022-08-09 | Fix error when switching to another `GridMap` with an item with higher index ↵ | Michael Alexsander | |
selected | |||
2022-07-29 | Remove Signal connect binds | Juan Linietsky | |
Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind() | |||
2022-07-28 | Merge pull request #57698 from ↵ | Rémi Verschelde | |
bluenote10/feature/rename_translated_to_translated_local | |||
2022-07-18 | Rename Control PRESET_WIDE to PRESET_FULL_RECT | FireForge | |
2022-07-16 | rename translate(d) to translate(d)_local in Transform 2D/3D | Fabian Keller | |
2022-06-16 | Move duplicate AutoWrap, Overrun and VisibleChar behavior enums to the ↵ | bruvzg | |
TextServer. | |||
2022-05-28 | Use consistent casing in editor filter/search bars | FireForge | |
2022-05-16 | Merge pull request #58624 from dzil123/fix_update_gridmap_cursor | Rémi Verschelde | |
2022-05-06 | Cleanup metadata usage | kobewi | |
2022-04-04 | Zero initialize all pointer class and struct members | Rémi Verschelde | |
This prevents the pitfall of UB when checking if they have been assigned something valid by comparing to nullptr. | |||
2022-04-02 | fix gridmap cursor showing the wrong mesh | dzil123 | |
2022-03-28 | Modules: Don't build editor-specific classes in templates | Rémi Verschelde | |
They're moved to an `editor` subfolder so that we can easily handle them separately. |