Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
|
|
|
|
Reenable checking those when validating code.
|
|
|
|
Also store Variant operator to avoid needing to do it repeatedly in
later compiling stages.
|
|
|
|
Sometimes to fix something you have to break it first.
This get GDScript mostly working with the new tokenizer and parser but
a lot of things isn't working yet. It compiles and it's usable, and that
should be enough for now.
Don't worry: other huge commits will come after this.
|
|
Fix: #39909
|
|
Added shadowed var warning for `for` loop counter
|
|
GDScript debugger stepping to incorrect line fix
|
|
Tweak the GDScript error message about passed argument type mismatch
|
|
Fix: #39296
|
|
This makes it less confusing.
This closes https://github.com/godotengine/godot-proposals/issues/670.
|
|
|
|
Fix: #39268
|
|
Trigger an error when trying to define a preexisting signal in GDScript
|
|
Depending on the conditional statements of the 'for' and 'while' loops,
their body may not even execute once. For example:
func a():
var arr = []
for i in arr:
return i
# can be reached, but analysis says cannot
return -1
func b():
var should_loop = false
while should_loop:
return 1
# can be reached, but analysis says cannot
return 0
The parser will complain that the statements after the comment cannot
be reached, but it is clearly possible for our scenario. This is
because the parser falsely assumes that the loop body will always
execute at least once.
Fix the code to remove this assumption for both of those loops.
|
|
|
|
Style: Remove new line at block start, enforce line between functions, enforce braces in if and loop blocks
|
|
Using clang-tidy's `readability-braces-around-statements`.
https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
|
|
set parser error when infer type is null
|
|
I couldn't find a tool that enforces it, so I went the manual route:
```
find -name "thirdparty" -prune \
-o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \
-o -name "*.glsl" > files
perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files)
misc/scripts/fix_style.sh -c
```
This adds a newline after all `}` on the first column, unless they
are followed by `#` (typically `#endif`). This leads to having lots
of places with two lines between function/class definitions, but
clang-format then fixes it as we enforce max one line of separation.
This doesn't fix potential occurrences of function definitions which
are indented (e.g. for a helper class defined in a .cpp), but it's
better than nothing. Also can't be made to run easily on CI/hooks so
we'll have to be careful with new code.
Part of #33027.
|
|
Which means that reduz' beloved style which we all became used to
will now be changed automatically to remove the first empty line.
This makes us lean closer to 1TBS (the one true brace style) instead
of hybridating it with some Allman-inspired spacing.
There's still the case of braces around single-statement blocks that
needs to be addressed (but clang-format can't help with that, but
clang-tidy may if we agree about it).
Part of #33027.
|
|
shadowed var warning in nested block bug fix
|
|
|
|
ThakeeNathees/range-crash-with-non-numeric-const-fix
range() with non-numeric const argument crash fix
|
|
regression: var declaration type info parser bug fix
|
|
|
|
|
|
Part of #33027.
|
|
Part of #33027, also discussed in #29848.
Enforcing the use of brackets even on single line statements would be
preferred, but `clang-format` doesn't have this functionality yet.
|
|
Allow using integer vectors for iteration and make range() use them
|
|
Fix: #38552
|
|
|
|
|
|
GDScript class var type resolve bug fixed
|
|
parser error for static func access non-static variables
|
|
A minor bugfix
|
|
|
|
Improved go-to definition (Ctrl + Click)
|
|
Co-Authored-By: Bojidar Marinov <bojidar.marinov.bg@gmail.com>
|
|
Fix: #38408
|
|
|
|
Calling _reduce_node_type from GDScriptParser::_parse_block for assert
was using a current class with a scope that didn't include all
functions. Now calling in GDScriptParser::_check_block_types uses the
right class type. We also now check the assert node message. The assert
line was added to the set_errors associated with assert, since before
the error would be reported on the next line
|
|
Fix: export var type reduce() implemented
|
|
|
|
Mark assert lines as safe in gdscript
|