summaryrefslogtreecommitdiff
path: root/modules/gdscript/gdscript_parser.cpp
AgeCommit message (Collapse)Author
2020-06-05Merge pull request #39301 from Calinou/fix-argument-parameter-confusionRémi Verschelde
Tweak the GDScript error message about passed argument type mismatch
2020-06-04Tweak the GDScript error message about passed argument type mismatchHugo Locurcio
This makes it less confusing. This closes https://github.com/godotengine/godot-proposals/issues/670.
2020-06-04predefined var check for `for` loop counterThakee Nathees
2020-05-21Merge pull request #33689 from jbuck3/signal-errorRémi Verschelde
Trigger an error when trying to define a preexisting signal in GDScript
2020-05-16gdscript_parser: Fix "unreachable code" false positive for loopsTan Wang Leng
Depending on the conditional statements of the 'for' and 'while' loops, their body may not even execute once. For example: func a(): var arr = [] for i in arr: return i # can be reached, but analysis says cannot return -1 func b(): var should_loop = false while should_loop: return 1 # can be reached, but analysis says cannot return 0 The parser will complain that the statements after the comment cannot be reached, but it is clearly possible for our scenario. This is because the parser falsely assumes that the loop body will always execute at least once. Fix the code to remove this assumption for both of those loops.
2020-05-15break, continue outside of a loop, match statement handledThakee Nathees
2020-05-14Merge pull request #38738 from akien-mga/cause-we-never-go-out-of-styleRémi Verschelde
Style: Remove new line at block start, enforce line between functions, enforce braces in if and loop blocks
2020-05-14Style: Enforce braces around if blocks and loopsRémi Verschelde
Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14Merge pull request #38610 from ThakeeNathees/infer-type-null-errorRémi Verschelde
set parser error when infer type is null
2020-05-14Style: Enforce separation line between function definitionsRémi Verschelde
I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocksRémi Verschelde
Which means that reduz' beloved style which we all became used to will now be changed automatically to remove the first empty line. This makes us lean closer to 1TBS (the one true brace style) instead of hybridating it with some Allman-inspired spacing. There's still the case of braces around single-statement blocks that needs to be addressed (but clang-format can't help with that, but clang-tidy may if we agree about it). Part of #33027.
2020-05-14Merge pull request #38611 from ThakeeNathees/shadow-var-warning-bug-fixRémi Verschelde
shadowed var warning in nested block bug fix
2020-05-13set parser error when infer type is nullThakee Nathees
2020-05-13Merge pull request #38609 from ↵Rémi Verschelde
ThakeeNathees/range-crash-with-non-numeric-const-fix range() with non-numeric const argument crash fix
2020-05-13Merge pull request #38708 from ThakeeNathees/init-assign-type-parser-bug-fixRémi Verschelde
regression: var declaration type info parser bug fix
2020-05-13regression: static func can't access const fixThakee Nathees
2020-05-13regression: var declaration type info parser bug fixThakee Nathees
2020-05-10Style: clang-format: Disable AllowShortCaseLabelsOnASingleLineRémi Verschelde
Part of #33027.
2020-05-10Style: clang-format: Disable AllowShortIfStatementsOnASingleLineRémi Verschelde
Part of #33027, also discussed in #29848. Enforcing the use of brackets even on single line statements would be preferred, but `clang-format` doesn't have this functionality yet.
2020-05-10Merge pull request #37020 from aaronfranke/rangeRémi Verschelde
Allow using integer vectors for iteration and make range() use them
2020-05-10shadowed var warning in nested block bug fixThakee Nathees
Fix: #38552
2020-05-10range() with non-numeric const argument crash fixThakee Nathees
2020-05-10more clearer unexpected statement end error messagesThakee Nathees
2020-05-09Merge pull request #37598 from ThakeeNathees/GDScript-type-resolve-bug-fixRémi Verschelde
GDScript class var type resolve bug fixed
2020-05-09Merge pull request #38412 from ThakeeNathees/static-func-var-accessRémi Verschelde
parser error for static func access non-static variables
2020-05-09Change get_completion_identifier_is_function to return a boolAaron Franke
A minor bugfix
2020-05-09Allow using integer vectors for iteration and make range() use themAaron Franke
2020-05-05Merge pull request #37293 from Janglee123/ctrl-click-improvementsRémi Verschelde
Improved go-to definition (Ctrl + Click)
2020-05-05Improved go-to definition (Ctrl + Click)janglee
Co-Authored-By: Bojidar Marinov <bojidar.marinov.bg@gmail.com>
2020-05-03parser error for static func access non-static variablesThakee Nathees
Fix: #38408
2020-05-02Mention offending function name in "Indented block expected" errorSteven Schoen
2020-04-27Fix for marking assert lines as safe bugTom Evans
Calling _reduce_node_type from GDScriptParser::_parse_block for assert was using a current class with a scope that didn't include all functions. Now calling in GDScriptParser::_check_block_types uses the right class type. We also now check the assert node message. The assert line was added to the set_errors associated with assert, since before the error would be reported on the next line
2020-04-27Merge pull request #36927 from ThakeeNathees/export-var-type-reduce-implimentedRémi Verschelde
Fix: export var type reduce() implemented
2020-04-27export var type reduce() implementedThakee Nathees
2020-04-24Merge pull request #37265 from BigRed-118/mark_assert_safeRémi Verschelde
Mark assert lines as safe in gdscript
2020-04-24Merge pull request #37232 from ThakeeNathees/load()-autocomplete-imlpementedRémi Verschelde
autocomplete for load() function implemented
2020-04-21Merge pull request #37537 from ThakeeNathees/const-parsing-datatype-bug-fixRémi Verschelde
GDScript: Fix type inference for const reference to global class
2020-04-21Merge pull request #37712 from stoofin/pattern-bind-warningRémi Verschelde
Fix unassigned variable warnings for match bindings
2020-04-21Merge pull request #38041 from ThakeeNathees/class-name-check-enhanceRémi Verschelde
GDScript class name existance check enhanced
2020-04-21Merge pull request #37955 from ThakeeNathees/lin-unsafe-base-know-index-unkonwnRémi Verschelde
Line marked unsafe when base known and index unkonwn
2020-04-20Fix handling of PROPERTY_USAGE_SUBGROUP in DocData and editorRémi Verschelde
Subgroups were added in #37678 but not properly handled everywhere where PROPERTY_USAGE_GROUP is.
2020-04-20GDScript class name existance check enhancedThakee Nathees
2020-04-17line unsafe for indexing with known base type & unkown identifierThakee Nathees
2020-04-10Merge pull request #37395 from ThakeeNathees/collon-equal-parser-bug-fixRémi Verschelde
`:=` fails on some nodes fix: #37357
2020-04-09Pattern bind counts as assignmentStoofin
Fixes #34697
2020-04-05GDScript class var type resolve bug fixedThakee Nathees
Fix: #37545
2020-04-03GDScript: Fix type inference for const reference to global classThakee Nathees
Fixes #37529.
2020-04-02Replace NULL with nullptrlupoDharkael
2020-03-29`:=` fails on some nodes fix: #37357Thakee Nathees
2020-03-28Fix for loop range bug: #37358Thakee Nathees