summaryrefslogtreecommitdiff
path: root/editor
AgeCommit message (Collapse)Author
2023-03-14Don't unset local_coords on starting transform.Ryan Roden-Corrent
This fixes a bug introduced by 806425621cfa3daba3ba9f6b020726490a3152a4, where dragging the gizmo no longer respected local transforms. I'm not sure why I called set_local_coords_enabled(false) in _compute_edit. Removing this line seems to fix gizmo-dragging local transforms, without breaking anything else. I also noticed that confirming a transform leaves the gizmo axis lines on the screen. This is fixed by calling update_transform_gizmo after clearing the edit mode/instant flags, so update_transform_gizmo knows not to render any axes. (cherry picked from commit d3d1223b970140b6a37d0c23e3b234c878be510a)
2023-03-14Disable local space for blender transforms.Ryan Roden-Corrent
Having local_space enabled when starting a transform changed the behavior of VIEW space transforms. Now we disable local_space when starting a blender transform (there was already logic to restore the setting after the transform ends). This also hides the gizmo while performing a blender transform, otherwise the user will see it snap back and forth between the local and global alignment. I think the transform looks cleaner with the gizmo hidden anyways. Fixes #59392. (cherry picked from commit 806425621cfa3daba3ba9f6b020726490a3152a4)
2023-03-14FBX: Disable importer when canceling FBX2glTF setupRémi Verschelde
Pretty hacky solution but it's better than an infinite loop. All this import setup needs to be redone, it's very difficult to properly bail out from an invalid import without triggering reimport loops. Also fix underline not visible at default editor scale in LinkButton. Fixes #73319. (cherry picked from commit d81e6ee024a8c64b80ac25c96b33c749ba1db79d)
2023-03-13Add missing handler for removing font sizes in ThemesYuri Sizov
(cherry picked from commit 5a3dbea3ed95b6b1ff0847daf1669aa88515801b)
2023-03-13Fix type icons in `PropertySelector`Ninni Pipping
And adding a check to prevent future issues. (cherry picked from commit ca86d53e7f9c6f9785f5ef48917e92d41296f984)
2023-03-13remove incorrect rename of get_used_cells_by_idThomas Lobig
renaming get_used_cells_by_id to get_used_cells is not only unecessary, it introduces hard to debug issues (cherry picked from commit d6a2197b3d5b50bc8d0b31c97d0abeaafe80269e)
2023-03-13Add parentheses around arguments when converting xformclayjohn
(cherry picked from commit 3ee5fbdb73fbdec318a345cc797d2d1daf19895f)
2023-03-13Add some missing renames to 3to4 tool.Ryan Roden-Corrent
MultiplayerPeerExtension isn't an exact replacement for NetworkedMultiplayerCustom, but at least it gets you moving in the right direction. Engine.editor_hint couldn't be fixed by the renames map, because you have to add a `()` at the end. (cherry picked from commit 6b17c2b6e79adfbcd349ac16e1a1d31098562bc5)
2023-03-13Move tool declarations to top in 3to4.Ryan Roden-Corrent
In godot3, `tool` can follow keywords like `extends` and `class_name` In godot4, `@tool` must be the first line in the file. (cherry picked from commit 9a474fb99f18782b2fcafa750c1b899996e79737)
2023-03-13Project Converter: Do not convert lines that start with a commentMarius Hanl
Lines that start with # or // are ignored (cherry picked from commit 8cf7ac3a4509a5c42fe32099ea05e99311b9a2a9)
2023-03-13Add keycode project conversionNinni Pipping
(cherry picked from commit fec630f360b93fa221acb7d47efd7aa9b1605801)
2023-03-13Fix Camera2D position smoothing properties not being groupedMarcus Elg
(cherry picked from commit a835dfd96d2a758fb194237954f0d4824ff08e05)
2023-03-13Correct superclass constructors in 3to4.Ryan Roden-Corrent
Fixes #70542. The 3to4 conversion tool was not handling superclass constructors. We should translate the godot3 syntax: ```gdscript func _init(a,b,c).(a,b,c): pass func _init(a,b,c): super(a,b,c) ``` Originally, the _init conversion was intended to remove `void` return types from _init functions, as this was disallowed due to #50589. As that was resolved by #53366, I removed that part of the conversion logic. If a void return type is present on a constructor, the converter now leaves it. Here's a sample diff from my own project: ```diff @@ -103,10 +105,11 @@ class Real: class Text: extends Setting - var choices: PoolStringArray - var value: String setget set_value, get_value + var choices: PackedStringArray + var value: String : get = get_value, set = set_value - func _init(section: String, key: String, default: String, choice_list: Array).(section, key, default) -> void: + func _init(section: String, key: String, default: String, choice_list: Array) -> void: + super(section, key, default) choices = choice_list func normalize(val): @@ -129,9 +132,10 @@ class Text: class Boolean: extends Setting - var value: bool setget set_value, get_value + var value: bool : get = get_value, set = set_value - func _init(section: String, key: String, default: bool).(section, key, default) -> void: + func _init(section: String, key: String, default: bool) -> void: + super(section, key, default) pass ``` (cherry picked from commit 53a00abb11cbbdceba7f7d027e7455854bfef01e)
2023-03-13Don't strip whitespace when converting 3to4.Ryan Roden-Corrent
Fixes #74204. The style guide says > Always use one space around operators and after commas The 3to4 conversion tool currently strips space in certain scenarios. I've updated it to add space whenever it is generating new code. In any case where it substitutes existing code, it leaves it as-is. For example, connect(a,b,c) becomes `connect(a, callable(b, c))`, because the converter is adding new commads/parens. However, `xform(Vector3(a,b,c))` becomes `Transform * Vector3(a,b,c)` because it uses the user's original Vector3 string whole. If the user originally had `xform(Vector3(a, b, c))`, then it becomes `Transform * Vector3(a, b, c)`. Ideally we'd always preserve original formatting, but this seems quite difficult, so I tried to preserve it where we can, but air on the side of following the style guide whenever we're transforming code. (cherry picked from commit d3684e662fdf2611214efc721ea2276364ef9fe1)
2023-03-13Fix TileSetEditor paiting texture_origin Vector2iNinni Pipping
(cherry picked from commit fb317546fe4ded0c5ea192ae9a870722a0d6e59c)
2023-03-13Fix dock name lost translation after layout changeHaoyu Qiu
* After you click in the dock select panel * After you load an editor layout (cherry picked from commit 43bf0ca8d28de43ab0eeb7063bbaee01dd091d0e)
2023-03-13Automatically reparent editor message dialogs to avoid error spam.bruvzg
(cherry picked from commit 921f3b7589084e07a4b6eefd89ec7fe81857a8b7)
2023-03-13Stop toaster notification circle flickering when notifications are all hidden.SaracenOne
(cherry picked from commit ab61624c786f0e1556eacf374eaca2838edb9bec)
2023-03-13TileSet editor was out of sync with TileMap and incorrectly overwrote old ↵Niels Drost
selected TileSet after an edit call with a null pointer. (cherry picked from commit 66374c8dcee3eab1e0878e892be32cd257b43a5b)
2023-03-13Fix GDScript code style regarding colonDanil Alexeev
(cherry picked from commit ea5fd3d732a85029e8372425904971ad26153ff1)
2023-03-13Document `editor/naming/scene_name_casing` settingNinni Pipping
Moved definitions of editor related project settings to `editor/register_editor_types.cpp` to make documentation work. (cherry picked from commit 3de5332fcb31ea46a692fda7b92847b162e3571d)
2023-03-13Improve logic related to editing audio buses (and prevent crashes)Yuri Sizov
(cherry picked from commit 68c18c0e2b8cb7c0e0f850f9bbdde31e30d166cf)
2023-03-13Prevent cache corruption when saving resources in the editorYuri Sizov
(cherry picked from commit 496bd94c21dbda01fc7d9d0a108eecef21924024)
2023-03-13Fix crash when revealing file in floating FileSystem DockHayden Leete
When selecting "Show in FileSystem" from the context menu of a resource in the inspector, the engine would crash if the FileSystem dock was floating because it was trying to focus the FileSystem tab, but floating docks don't use Tab Containers. This commit makes the FileSystem dock's window grab focus instead if it's floating. (cherry picked from commit c4d1513e15e1f3e599030a98cf425177c3d1eb24)
2023-03-13Generate empty textures for theme icons if the SVG module is disabledYuri Sizov
(cherry picked from commit 64215ad1192878b72e784c5a62ea9b2dba0520dd)
2023-03-11Ensure that editor color map is initialized in the project managerYuri Sizov
2023-03-06Fix "Convert Full Project" button not translatedHaoyu Qiu
Also fixes a typo in the CHANGELOG. (cherry picked from commit e03bfd6f7fef1845dff544a3b0acb62d2af2b0ad)
2023-03-01i18n: Sync translations with WeblateRémi Verschelde
2023-02-27Fix a crash in the GLB importerGilles Roudière
2023-02-27Add 3-to-4 renames for project settings in project.godotRémi Verschelde
In the ConfigFile format, the first subpath is the category and is not part of the line that the regex would match. Fixes #66125.
2023-02-27Cleanup 3-to-4 renames, prevent common words replacementsRémi Verschelde
Fixes #73505. Fixes #73996.
2023-02-26Merge pull request #73959 from clayjohn/GL-mobile-warningsRémi Verschelde
Add warnings for unsupported features in mobile and gl_compatibility backends
2023-02-26Add warnings for unsupported features in mobile and gl_compatibility backendsclayjohn
2023-02-26Merge pull request #73954 from KoBeWi/BugExRémi Verschelde
Fix wrong OS regex in project converter
2023-02-26Converter: Rename 3.x Vector2 clamped to limit_lengthThomas Lobig
2023-02-26Fix wrong OS regex in project converterkobewi
2023-02-25Merge pull request #73887 from nklbdev/masterRémi Verschelde
fix typo `set_polygon` in GenericTilePolygonEditor
2023-02-25fix typo `set_polygon` in GenericTilePolygonEditornklbdev
2023-02-24Revert "Reordering emitted signals in PopupMenu" and fix editor selection ↵bruvzg
issue in the safer way.
2023-02-24i18n: Sync translations with WeblateRémi Verschelde
2023-02-24Merge pull request #73855 from ↵Rémi Verschelde
CheesecakeCG/scene-import-animationlibrary-tab-fix Fix settings not appearing for Animation Libraries in the Scene Import window
2023-02-23Fix settings not appearing for Animation Libraries in the Scene Import windowhare_ware
2023-02-23Fix editor resource preview deadlocking with --headless modeGordon MacPherson
2023-02-23Export: Default to exporting S3TC + BPTC for PC platformsRémi Verschelde
This is now required after #72031 when using HDRs. Could have further cleanup as I think these import options may not be needed at all anymore, and etc/etc2 support doesn't seem to make much sense. Likewise, the hardcoded "s3tc" in `get_platform_features` could maybe be removed. But this is material for after 4.1. Fixes #73789.
2023-02-23Merge pull request #73814 from lyuma/importer_mesh_convexRémi Verschelde
import: Fix uv2 by avoiding premature ImporterMesh::get_mesh()
2023-02-23Merge pull request #73775 from ↵Rémi Verschelde
SaracenOne/fix_node_ownership_on_scene_update_addition Fix ownership bug on ancestor nodes when scene is reimported
2023-02-23Merge pull request #73687 from ↵Rémi Verschelde
Calinou/editor-convex-import-fix-max-convex-hulls-crash Add a property hint to fix crash when setting max convex hulls below 0
2023-02-23Add a property hint to fix crash when setting max convex hulls below 0Hugo Locurcio
Generating less than 1 convex hull is not valid anyway.
2023-02-23import: Fix uv2 by avoiding premature ImporterMesh::get_mesh()Lyuma
Implements create_convex_shape in ImpoterMesh. Note: ImporterMeshInstance3D::get_mesh() is safe. The only dangerous function with side effects is ImpoterMesh::get_mesh()
2023-02-23import: Pass the correct defaults to generated collision shapes.Lyuma
Solves incorrect defaults, as well as applied scale failing to apply. The default values are removed, and they differ from collision shape defaults These values must match the defaults defined in resource_importer_scene.cpp
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-25 18:34:02 +0000