summaryrefslogtreecommitdiff
path: root/editor/editor_inspector.cpp
AgeCommit message (Collapse)Author
2023-01-08Use BitField<> in core type masksJuan Linietsky
* All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-05One Copyright Update to rule them allRémi Verschelde
As many open source projects have started doing it, we're removing the current year from the copyright notice, so that we don't need to bump it every year. It seems like only the first year of publication is technically relevant for copyright notices, and even that seems to be something that many companies stopped listing altogether (in a version controlled codebase, the commits are a much better source of date of publication than a hardcoded copyright statement). We also now list Godot Engine contributors first as we're collectively the current maintainers of the project, and we clarify that the "exclusive" copyright of the co-founders covers the timespan before opensourcing (their further contributions are included as part of Godot Engine contributors). Also fixed "cf." Frenchism - it's meant as "refer to / see".
2023-01-04Revert "Merge pull request #70696 from Rindbee/propagate-keying-state"Silc Renew
This reverts commit c774b4ce1777d19789bec1cbef100f26c6927777, reversing changes made to ccc609d824802d1d1a20f34bda69ecac75f5a8a1.
2023-01-04Revert "Merge pull request #68498 from Rindbee/improve-update_tree"Silc Renew
This reverts commit d5dc70a47871701fc61804b0b75362f5dcdf0055, reversing changes made to ccbefa1f4316c46eed35912e954fdf0e8c88c01a.
2022-12-31Propagate the keying state in the inspectorRindbee
Toggling the keying state does not significantly change the structure of the inspector. So it's ok to propagate the keying state and then use `queue_redraw()` to update the keying icon.
2022-12-22Revert "Queue inspector tree update when changing the theme."Rémi Verschelde
This reverts commit c0baec410b0617ddb36c278230f3b60da1444af6. See comments in #70381.
2022-12-21Merge pull request #70261 from Maran23/4-x-editor-inspector-section-clickRémi Verschelde
EditorInspectorSection is not (un)folded when clicking under the font
2022-12-21Queue inspector tree update when changing the theme.Marius Hanl
2022-12-18EditorInspectorSection is not folded when clicking under the fontMarius Hanl
2022-12-17Defer `EditorInspector::update_tree` to the process stage to improve performanceRindbee
`EditorInspector::update_tree` is expensive, so defer the call to the process phase to prevent multiple calls in a single frame (when switching scene tabs).
2022-11-29Merge pull request #67814 from opl-/fix/editor-inspector-accept-eventRémi Verschelde
Fix editor inspector classes not accepting events
2022-11-29Use forward-declarations in big editor classestrollodel
2022-11-23Fix for documentation not appearing in preview in editor inspectorBrunoSXS
2022-11-02Unify usage of undo_redo in editorkobewi
2022-10-31Merge pull request #67578 from KoBeWi/GEDITORRémi Verschelde
Unify usage of GLOBAL/EDITOR_GET
2022-10-31Merge pull request #67588 from KoBeWi/if(!GDVIRTUAL_CALL)don'tRémi Verschelde
Simplify GDVIRTUAL_CALL calls
2022-10-31Fix `EditorInspector.property_changed` signal connectionDanil Alexeev
2022-10-23Fix editor inspector classes not accepting eventsopl-
2022-10-19Simplify GDVIRTUAL_CALL callskobewi
2022-10-18Unify usage of GLOBAL/EDITOR_GETkobewi
2022-10-07Fix MSVC warnings, rename shadowed variables, fix uninitialized values, ↵bruvzg
change warnings=all to use /W4.
2022-09-30Rename Copy Property –> Copy ValueVolTer
2022-09-30Fix typos with codespellRémi Verschelde
Using codespell 2.3-dev from current git. And fix typo in `methods.py` for `vsproj=yes` option (still won't work though).
2022-09-21Fix EditorInspectorCategory minimum size calculationRindbee
Calculated using the same theme property values as in `NOTIFICATION_DRAW`, keeping the width at `0` and calculating only the height.
2022-09-19Merge pull request #66108 from Zylann/editor_inspector_get_selected_pathRémi Verschelde
Expose `EditorInspector.get_selected_path`
2022-09-19Expose `EditorInspector.get_selected_path`Marc Gilleron
2022-09-19Expose `EditorProperty._set_read_only` virtual methodMarc Gilleron
2022-09-16Merge pull request #60786 from Rindbee/update-editor-property-statusRémi Verschelde
Update checked based on the variant type of the value
2022-09-16Merge pull request #65868 from timothyqiu/metadata-crashRémi Verschelde
Fix crash open opening Add Metadata dialog
2022-09-16Fix crash open opening Add Metadata dialogHaoyu Qiu
2022-09-15Fix empty text in the add button when editing nodes with itemsMichael Alexsander
2022-09-16Update checked based on the variant type of the valueRindbee
In `EditorProperty::update_revert_and_pin_status`, if `checkable` is `true`, update `checked` based on the variant type of the value, and rename the function as `EditorProperty::update_editor_property_status`. **Known problems:** 1. Unable to check Checkbox for properties of type `Object` when it is unchecked. This is probably because during value store/fetch, the `nullptr` (variant type is `Variant::OBJECT`) eventually becomes `Variant()` (variant type is `Variant::NIL`). 2. For theme overrides, click the revert icon will uncheck the Checkbox. This is probably because `EditorPropertyRevert::get_property_revert_value` returns `Variant()`.
2022-09-14Merge pull request #65430 from SaracenOne/read_only_arrayRémi Verschelde
Add read-only mode to inspector array and dictionary viewer.
2022-09-08Make `Vector2i` values paired with `EDSCALE` be just `Vector2`Michael Alexsander
2022-09-07Fix key mapping changes when moving from macOS to other platformbruvzg
Removes separate `Command` key (use `Meta` instead). Adds an event flag to automatically remap `Command` <-> `Control` (cannot be set alongside `Control` or `Meta`).
2022-09-07Merge pull request #58617 from KoBeWi/custom_somethingRémi Verschelde
Improve handling of custom types
2022-09-06Improve naming of theme properties throughout GUI codeYuri Sizov
Rename ItemList's bg -> panel Rename ItemList's bg_focus -> focus Rename ProgressBar's bg -> background Rename ProgressBar's fg -> fill Rename Tree's bg -> panel Rename Tree's bg_focus -> focus Rename ScrollContainer's bg -> panel Rename FileDialog's *_icon_modulate -> *_icon_color Rename FileDialog's files_disabled -> file_disabled_color Rename CheckButton's on/off -> checked/unchecked Rename check_v_adjust -> check_v_offset
2022-09-06Add read-only mode to inspector array and dictionary viewer.SaracenOne
2022-09-05Improvements to multi-node editingFireForge
- Show revert button for properties that are not default for all selected nodes - Show property documentation tooltips - Show common class name and icon and number of selected nodes in EditorPath, e.g. "Node2D (4 Selected)" - Hide metadata for MultiNodeEdit and AnimationMultiTrackKeyEdit - Hide script for MultiNodeEdit
2022-09-05Improve handling of custom typeskobewi
2022-09-01Improve the editor's Add Metadata dialogHugo Locurcio
- Mention the node name in the dialog title. - Improve error messages to be more descriptive.
2022-08-30Merge pull request #64377 from Mickeon/rename-canvas-redrawRémi Verschelde
Rename `CanvasItem.update()` to `queue_redraw()`
2022-08-29Add missing parameters for signal in docsAtlinx
2022-08-29Rename `CanvasItem.update()` to `queue_redraw()`Micky
Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-29Revert "Remove NOTIFICATION_ENTER_TREE when paired with ↵Rémi Verschelde
NOTIFICATION_THEME_CHANGED" This reverts commit 4b817a565cab8af648c88cfc7ab6481e86ee3625. Fixes #64988. Fixes #64997. This caused several regressions (#64988, #64997, https://github.com/godotengine/godot/issues/64997#issuecomment-1229970605) which point at a flaw in the current logic: - `Control::NOTIFICATION_ENTER_TREE` triggers a *deferred* notification with `NOTIFCATION_THEME_CHANGED` as introduced in #62845. - Some classes use their `THEME_CHANGED` to cache theme items in member variables (e.g. `style_normal`, etc.), and use those member variables in `ENTER_TREE`, `READY`, `DRAW`, etc. Since the `THEME_CHANGE` notification is now deferred, they end up accessing invalid state and this can lead to not applying theme properly (e.g. for EditorHelp) or crashing (e.g. for EditorLog or CodeEdit). So we need to go back to the drawing board and see if `THEME_CHANGED` can be called earlier so that the previous logic still works? Or can we refactor all engine code to make sure that: - `ENTER_TREE` and similar do not depend on theme properties cached in member variables. - Or `THEME_CHANGE` does trigger a general UI update to make sure that any bad theme handling in `ENTER_TREE` and co. gets fixed when `THEME_CHANGE` does arrive for the first time. But that means having a temporary invalid (and possibly still crashing) state, and doing some computations twice which might be heavy (e.g. `EditorHelp::_update_doc()`).
2022-08-28Merge pull request #64885 from Mickeon/rename-tooltip-hintRémi Verschelde
Rename `hint_tooltip` to `tooltip_text` & setter getter
2022-08-27Remove NOTIFICATION_ENTER_TREE when paired with NOTIFICATION_THEME_CHANGEDAaron Record
2022-08-27Rename `hint_tooltip` to `tooltip_text` & setgetMicky
`hint_tooltip` -> `tooltip_text` `set_tooltip` -> `set_tooltip_text` `_get_tooltip` -> `get_tooltip_text` Updates documentation, too.
2022-08-26Remove Inspector tooltip hack that never actually workedYuri Sizov
2022-08-25Merge pull request #64270 from timothyqiu/close-keyingRémi Verschelde
Fix overlapping keying and remove button in Inspector