summaryrefslogtreecommitdiff
path: root/editor/editor_file_dialog.cpp
AgeCommit message (Collapse)Author
2022-08-29Rename String `plus_file` to `path_join`Aaron Franke
2022-08-29Revert "Remove NOTIFICATION_ENTER_TREE when paired with ↵Rémi Verschelde
NOTIFICATION_THEME_CHANGED" This reverts commit 4b817a565cab8af648c88cfc7ab6481e86ee3625. Fixes #64988. Fixes #64997. This caused several regressions (#64988, #64997, https://github.com/godotengine/godot/issues/64997#issuecomment-1229970605) which point at a flaw in the current logic: - `Control::NOTIFICATION_ENTER_TREE` triggers a *deferred* notification with `NOTIFCATION_THEME_CHANGED` as introduced in #62845. - Some classes use their `THEME_CHANGED` to cache theme items in member variables (e.g. `style_normal`, etc.), and use those member variables in `ENTER_TREE`, `READY`, `DRAW`, etc. Since the `THEME_CHANGE` notification is now deferred, they end up accessing invalid state and this can lead to not applying theme properly (e.g. for EditorHelp) or crashing (e.g. for EditorLog or CodeEdit). So we need to go back to the drawing board and see if `THEME_CHANGED` can be called earlier so that the previous logic still works? Or can we refactor all engine code to make sure that: - `ENTER_TREE` and similar do not depend on theme properties cached in member variables. - Or `THEME_CHANGE` does trigger a general UI update to make sure that any bad theme handling in `ENTER_TREE` and co. gets fixed when `THEME_CHANGE` does arrive for the first time. But that means having a temporary invalid (and possibly still crashing) state, and doing some computations twice which might be heavy (e.g. `EditorHelp::_update_doc()`).
2022-08-28Merge pull request #64885 from Mickeon/rename-tooltip-hintRémi Verschelde
Rename `hint_tooltip` to `tooltip_text` & setter getter
2022-08-27Remove NOTIFICATION_ENTER_TREE when paired with NOTIFICATION_THEME_CHANGEDAaron Record
2022-08-27Rename `hint_tooltip` to `tooltip_text` & setgetMicky
`hint_tooltip` -> `tooltip_text` `set_tooltip` -> `set_tooltip_text` `_get_tooltip` -> `get_tooltip_text` Updates documentation, too.
2022-07-29Remove Signal connect bindsJuan Linietsky
Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
2022-07-13Merge pull request #62827 from fire-forge/ok-cancelRémi Verschelde
Add `ok_button_text` to AcceptDialog and `cancel_button_text` to ConfirmationDialog
2022-07-09Seperate filter and description in FileDialog.add_filter()FireForge
2022-07-09Add ok_button_text to AcceptDialog and cancel_button_text to ConfirmationDialogFireForge
2022-07-04Fix FileDialog file name autocompletion with filtersThakee Nathees
Fixes #38195.
2022-06-16Move duplicate AutoWrap, Overrun and VisibleChar behavior enums to the ↵bruvzg
TextServer.
2022-05-10Cleanups after changes in ItemList signalsAleksey Smirnov
2022-05-06Changed signals of ItemListVitika9
2022-05-02Style: Partially apply clang-tidy's `cppcoreguidelines-pro-type-member-init`Rémi Verschelde
Didn't commit all the changes where it wants to initialize a struct with `{}`. Should be reviewed in a separate PR. Option `IgnoreArrays` enabled for now to be conservative, can be disabled to see if it proposes more useful changes. Also fixed manually a handful of other missing initializations / moved some from constructors.
2022-04-22Implement Label3D node.bruvzg
Add "generate_mipmap" font import option. Add some missing features to the Sprite3D. Move BiDi override code from Control to TextServer. Add functions to access TextServer font cache textures. Add MSDF related flags and shader to the standard material. Change standard material cache to use HashMap instead of Vector.
2022-04-11Make FileAccess and DirAccess classes reference counted.bruvzg
2022-04-06Restore hidden folder behavior for project managerEv1lbl0w
2022-04-05Fix Project Manager hard crashes due to invalid access to Editor NodesMarios Staikopoulos
2022-04-05[Input] Add extra `shortcut_input` input processing step to process Unicode ↵bruvzg
character input with Alt / Ctrl modifiers, after processing of shortcuts.
2022-03-28Merge pull request #59453 from DanielKriz/masterRémi Verschelde
2022-03-26Merge pull request #46638 from Ev1lbl0w/feature-hide_gdignored_dirsRémi Verschelde
2022-03-25Fix persistent favorites after renameDaniel Kříž
Signed-off-by: Daniel Kříž <Daniel.kriz@protonmail.com>
2022-03-25Add better alert dialogs if directory already existsDaniel Kříž
Signed-off-by: Daniel Kříž <Daniel.kriz@protonmail.com>
2022-03-12Merge pull request #58338 from aaronfranke/boolsRémi Verschelde
Initialize bools in the headers in `editor/`
2022-03-12Merge pull request #54399 from ↵Rémi Verschelde
Calinou/filedialog-current-properties-hint-no-editor Don't store and show current file/directory/path FileDialog properties
2022-03-12Initialize bools in the headers in editorAaron Franke
2022-03-12Allow negative indexes in ItemList and PopupMenukobewi
2022-03-02Allow absolute file paths in file dialogsmiremrie
2022-02-16Port existing _notification code to use switch statements (part 1/3)jmb462
2022-02-12Use EditorFileDialog instead of FileDialog in the project managerHendrik Brucker
2022-02-12Improve compilation speed (forward declarations/includes cleanup)Hendrik Brucker
2022-01-24[Windows] Add support for handling network share paths.bruvzg
2022-01-14Merge pull request #56706 from KoBeWi/we_need_to_go_higherRémi Verschelde
2022-01-12Automatically go up if current dir was deletedkobewi
2022-01-12Create function focus_file_textGer Hean
This function focuses the text field when saving a file It is called when the save file dialogue is opened
2022-01-03Update copyright statements to 2022Rémi Verschelde
Happy new year to the wonderful Godot community!
2022-01-03Merge pull request #55487 from YeldhamDev/scroll_bikesheddingRémi Verschelde
2021-12-09Replace String comparisons with "", String() to is_empty()Nathan Franke
Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-06Fix bad popups offset in editor with single window offjmb462
Co-authored-by: Gil Arasa Verge <gilarasaverge@gmail.com> Co-authored-by: Tomasz Chabora <kobewi4e@gmail.com>
2021-11-30Rename all methods that return `ScrollBar` nodes to `get_*_scroll_bar()`Michael Alexsander
2021-11-30Don't return reference on copy assignment operatorsRémi Verschelde
We prefer to prevent using chained assignment (`T a = b = c = T();`) as this can lead to confusing code and subtle bugs. According to https://en.wikipedia.org/wiki/Assignment_operator_(C%2B%2B), C++ allows any arbitrary return type, so this is standard compliant. This could be re-assessed if/when we have an actual need for a behavior more akin to that of the C++ STL, for now this PR simply changes a handful of cases which were inconsistent with the rest of the codebase (`void` return type was already the most common case prior to this commit).
2021-11-23Rename `remove()` to `remove_at()` when removing by indexLightning_A
2021-11-22Added `reset_size` method to `Control` and `Window` classesYuri Roubinsky
2021-11-12Use "enum class" for input enumsAaron Franke
2021-10-29Don't store and show current file/directory/path FileDialog propertiesHugo Locurcio
These properties are only useful at run-time, so they don't need to be displayed in the editor and stored.
2021-10-05Merge pull request #52711 from m4gr3d/provide_getter_for_project_data_dir_masterRémi Verschelde
2021-09-23Merge pull request #51920 from ↵Rémi Verschelde
jmb462/missing-sname-macro-optimization-in-some-functions
2021-09-15Provide a getter for the project data directory.ne0fhyk
2021-08-29Rename String::is_rel_path to String::is_relative_pathWilson E. Alvarez
2021-08-23Entirely removes BIND_VMETHOD in favor of GDVIRTUALreduz
* `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.