| Age | Commit message (Collapse) | Author |
|---|
|
NOTIFICATION_THEME_CHANGED"
This reverts commit 4b817a565cab8af648c88cfc7ab6481e86ee3625.
Fixes #64988.
Fixes #64997.
This caused several regressions (#64988, #64997,
https://github.com/godotengine/godot/issues/64997#issuecomment-1229970605)
which point at a flaw in the current logic:
- `Control::NOTIFICATION_ENTER_TREE` triggers a *deferred* notification with
`NOTIFCATION_THEME_CHANGED` as introduced in #62845.
- Some classes use their `THEME_CHANGED` to cache theme items in
member variables (e.g. `style_normal`, etc.), and use those member
variables in `ENTER_TREE`, `READY`, `DRAW`, etc. Since the `THEME_CHANGE`
notification is now deferred, they end up accessing invalid state and this
can lead to not applying theme properly (e.g. for EditorHelp) or crashing
(e.g. for EditorLog or CodeEdit).
So we need to go back to the drawing board and see if `THEME_CHANGED` can be
called earlier so that the previous logic still works?
Or can we refactor all engine code to make sure that:
- `ENTER_TREE` and similar do not depend on theme properties cached in member
variables.
- Or `THEME_CHANGE` does trigger a general UI update to make sure that any
bad theme handling in `ENTER_TREE` and co. gets fixed when `THEME_CHANGE`
does arrive for the first time. But that means having a temporary invalid
(and possibly still crashing) state, and doing some computations twice
which might be heavy (e.g. `EditorHelp::_update_doc()`).
|
|
Reorganize Label and RichTextLabel properties
|
|
Improve documentation for `get_animation()`
|
|
|
|
|
|
|
|
|
|
|
|
Fix crash when loading Animation Library after reloading a scene
|
|
Fix updating OccluderPolygon shapes
|
|
Add `dotnet format` to CI to check C# style
|
|
|
|
Fix various C# exceptions
|
|
C#: Ignore property indexers and report if exported
|
|
[DOCS] Update UPnP documentation
|
|
nongvantinh/inspector_resource_preview_incorrect_size
Fixed inspector resource preview shows up with incorrect size
|
|
|
|
|
|
|
|
|
|
|
|
Adds more details, especially about caveats, failure modes and pitfalls
|
|
Ignore property indexers since they are unsupported and report a
diagnostic if an user tries to export it.
|
|
faisal-alam09/Bugfix-#64836-Placeholder-scene-tab-not-removed-when-new-scene-created
Added a placeholder tab check before creating a new scene.
|
|
Rename `hint_tooltip` to `tooltip_text` & setter getter
|
|
Improve PackedScene instantiate
|
|
Add type icons to editor docs' hierarchy
|
|
Make `resource_local_to_scene` behave as described in the documentation. (If I understand correctly, the following **instance** refers to **the instance of the sub-scene**.)
https://github.com/godotengine/godot/blob/2e24b76535dceb9cf18ab8ece3304ed92948c1b5/doc/classes/Resource.xml#L70-L72
If the resources of the sub-scene are modified in the main scene, the modified resources will be recorded in the `tscn` file of the main scene. And the root node of the sub-scene will be set twice.
1. In the main scene, when encountering a sub-scene, the sub-scene will be initialized first;
2. Then use the resources in the main scene to reset the root node of the sub-scene.
This may make `resource_local_to_scene` not work as expected. The resources cannot be shared between the sub-scene root node and other ordinary nodes in the sub-scene.
Yes, if the resources have `resource_local_to_scene` enabled, this patch treats the modified resources of the sub-scene root node as resources in the sub-scene, not in the main scene. Although the modifications are recorded in the `tscn` file of the main scene.
|
|
rburing/solve_distance_world_boundary_motion_shape
Fix collision solving between world boundary and motion shape (3D)
|
|
|
|
|
|
|
|
|
|
|
|
C#: Fix byteCount in `NativeMemory.Alloc`
|
|
UPNP: Don't delete previous mappings when adding new port mappings
|
|
|
|
|
|
AaronRecord/remove_redundant_theme_updates_in_enter_tree
Remove `NOTIFICATION_ENTER_TREE` when paired with `NOTIFICATION_THEME_CHANGED`
|
|
Correct output file names for Visual Studio project generation
|
|
Fix editor shortcuts overrides overwriting user configured shortcuts.
|
|
|
|
|
|
|
|
|
|
|
|
Sync C# cubic interpolation with core
|
|
.NET: Change NETCore.App version detection to use highest match
|
|
Fix optimizer miscalculation and add optimization for `Animation::ValueTrack`
|
|
[Windows] Improve build environment detection, add support for Windows on ARM.
|