summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-04Fix unused variable and wrong warning workaroundRémi Verschelde
I had been looking at the wrong line all along when attempting to fix: ``` core/os/memory.cpp:184:13: warning: unused variable 's' [-Wunused-variable] uint64_t *s = (uint64_t *)mem; ^ ```
2018-10-04Merge pull request #22713 from akien-mga/fix-warningsRémi Verschelde
Fix GCC 8 warnings about potentially unitialized variables
2018-10-04Merge pull request #22693 from mineevgleb/fix-graphnode-titleRémi Verschelde
#21661: fixed GraphNode title offset
2018-10-04Merge pull request #22706 from GDquest/doc-texture-progressRémi Verschelde
[DOCS] Complete the TextureProgress reference
2018-10-04Fix TileMap editor drawingthe 8th mage
the tile cursor did not follow the mouse cursor, and the tile grid was displayed wrong, because the forward_canvas_draw_over_viewport function used the wrong xform and thus its map_to_world is not the inverse of the mouse interactor world_to_map, making the tiles draw from 0,0 of the screen instead of 0,0 of the tile map (which is in a different place)
2018-10-04Fix GCC 8 warnings about potentially unitialized variablesRémi Verschelde
Fixes the following GCC 8 warnings: ``` core/image.cpp:730:44: warning: 'mip1_weight' may be used uninitialized in this function [-Wmaybe-uninitialized] core/image.cpp:293:20: warning: 'mip2' may be used uninitialized in this function [-Wmaybe-uninitialized] core/image.cpp:293:20: warning: 'mip1' may be used uninitialized in this function [-Wmaybe-uninitialized] editor/audio_stream_preview.cpp:58:19: warning: 'vmax' may be used uninitialized in this function [-Wmaybe-uninitialized] editor/audio_stream_preview.cpp:85:19: warning: 'vmin' may be used uninitialized in this function [-Wmaybe-uninitialized] editor/editor_themes.cpp:306:53: warning: 'preset_contrast' may be used uninitialized in this function [-Wmaybe-uninitialized] editor/plugins/animation_blend_space_2d_editor.cpp:459:27: warning: 'prev_idx' may be used uninitialized in this function [-Wmaybe-uninitialized] editor/plugins/animation_blend_space_2d_editor.cpp:443:27: warning: 'prev_idx' may be used uninitialized in this function [-Wmaybe-uninitialized] main/tests/test_oa_hash_map.cpp:57:29: warning: 'value' may be used uninitialized in this function [-Wmaybe-uninitialized] modules/csg/csg.cpp:764:40: warning: 'max_angle' may be used uninitialized in this function [-Wmaybe-uninitialized] modules/csg/csg_shape.cpp:1945:3: warning: 'face_count' may be used uninitialized in this function [-Wmaybe-uninitialized] scene/3d/voxel_light_baker.cpp:1593:8: warning: 'cone_aperture' may be used uninitialized in this function [-Wmaybe-uninitialized] scene/3d/voxel_light_baker.cpp:1592:6: warning: 'cone_dir_count' may be used uninitialized in this function [-Wmaybe-uninitialized] scene/animation/animation_blend_space_2d.cpp:471:8: warning: 'mind' may be used uninitialized in this function [-Wmaybe-uninitialized] core/os/memory.cpp:94: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas] core/os/memory.cpp:95: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas] core/os/memory.cpp:98: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas] ```
2018-10-04Merge pull request #22620 from akien-mga/warnings-shall-not-passRémi Verschelde
SCons: Set default warnings level to all (-Wall or /W3)
2018-10-04Merge pull request #22710 from akien-mga/fix-warningsRémi Verschelde
Fix some OSX and iOS Clang warnings
2018-10-04Fix some OSX and iOS Clang warningsRémi Verschelde
Fixes the following XCode 9.4.1 warnings: ``` core/os/memory.cpp:175:13: warning: unused variable 's' [-Wunused-variable] drivers/coremidi/core_midi.cpp:68:14: warning: comparison between NULL and non-pointer ('MIDIEndpointRef' (aka 'unsigned int') and NULL) [-Wnull-arithmetic] drivers/gles2/rasterizer_gles2.cpp:77:24: warning: unused function '_gl_debug_print' [-Wunused-function,34] drivers/unix/thread_posix.cpp:106:12: warning: unused variable 'running_thread' [-Wunused-variable,34] modules/gdnative/nativescript/nativescript.h:371:16: warning: in-class initialization of non-static data member is a C++11 extension [-Wc++11-extensions] platform/iphone/gl_view.mm:56:14: warning: unused variable 'video_previous_volume' [-Wunused-variable,34] platform/iphone/gl_view.mm:251:12: warning: unused function 'get_first_id' [-Wunused-function,34] platform/iphone/main.m:45:15: warning: unused variable 'app' [-Wunused-variable,34] platform/osx/os_osx.mm:79:15: warning: unused function 'convertRectToBacking' [-Wunused-function] ```
2018-10-04SCons: Add 'werror' opt-in to treat warning as errorsRémi Verschelde
Also reorder advanced options to a more natural order, and fix MSVC warning when disabling warnings in secondary environment.
2018-10-04SCons: Set default warnings level to all (-Wall or /W3)Rémi Verschelde
2018-10-04Merge pull request #22708 from akien-mga/fix-warningsRémi Verschelde
Fix warnings about non-static data member initializers in nativescript
2018-10-04Fix warnings about non-static data member initializers in nativescriptRémi Verschelde
Fixes the following GCC/Clang warnings: ``` modules/gdnative/nativescript/nativescript.h:280:37: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11 modules/gdnative/nativescript/nativescript.h:281:37: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11 modules/gdnative/nativescript/nativescript.h:283:42: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11 modules/gdnative/nativescript/nativescript.h:285:38: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11 modules/gdnative/nativescript/nativescript.h:287:38: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11 modules/gdnative/nativescript/nativescript.h:290:45: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11 modules/gdnative/nativescript/nativescript.h:291:44: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11 ```
2018-10-04Merge pull request #22707 from karroffel/clang-warningsRémi Verschelde
fix enum cast warnings on clang
2018-10-04fix enum cast warnings on clangkarroffel
2018-10-04Merge pull request #22694 from swarnimarun/fix-create-spatial-rootRémi Verschelde
Fixing create spatial root button
2018-10-04[DOC] Complete the TextureProgress referenceNathan Lovato
Added 6 missing entries, clarified one definition
2018-10-04Fixing create spatial root buttonswarnimarun
2018-10-03#21661: fixed GraphNode title offsetGleb Mineev
2018-10-03Merge pull request #22659 from YeldhamDev/animation_doc_exampleRémi Verschelde
Add example to Animation doc
2018-10-03Merge pull request #22643 from akerudesu/dynamic_font_fallbackRémi Verschelde
Fix oversampling of DynamicFont fallback fonts
2018-10-03Merge pull request #22691 from jfmichaud31/fix_export_editorRémi Verschelde
Fix #22588: missing preset save after removing a export preset.
2018-10-03Merge pull request #22690 from jfmichaud31/fix_gles2_shaderRémi Verschelde
Fix #22591: shader error when shadow enabled
2018-10-03Fix lightmap baking crash, may close some issues but I am not sure.Juan Linietsky
2018-10-03Fix #22591: shader failed to compile when shadow enabled because of ↵Jean-François Michaud
incompatible assignment of vec3 to a vec4.
2018-10-03Fix #22588: missing preset save after removing a export preset.Jean-François Michaud
2018-10-03Merge pull request #22681 from akien-mga/fix-warningsRémi Verschelde
Fix warnings on release builds and some MSVC warnings
2018-10-03Merge pull request #22671 from Dragoncraft89/masterRémi Verschelde
ItemList signals additional documentation
2018-10-03Merge pull request #22674 from Dragoncraft89/find_nodeRémi Verschelde
Document find_node()'s owner argument behaviour
2018-10-03Merge pull request #22683 from qonnop/fix-dds-w-h-attribsRémi Verschelde
Fixed DDS loader width/height attribs, fixes #22530
2018-10-03Add example to Animation docMichael Alexsander Silva Dias
2018-10-03Document find_node()'s owner argument behaviourflorian
2018-10-03ItemList signals additional documentationflorian
Signals: * item_selected * item_rmb_select
2018-10-03Merge pull request #22675 from DualMatrix/duplicate_errRémi Verschelde
Fixed error when duplicating node with signal from editor.
2018-10-03Fix some warnings raised by MSVC 2017Rémi Verschelde
Disabled signed/unsigned warnings like for GCC/Clang (warning C4018: '>=': signed/unsigned mismatch). Fixes the following MSVC 2017 warnings: ``` core\image.cpp(999): warning C4804: '>': unsafe use of type 'bool' in operation core\io\compression.cpp(178): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) editor\doc\doc_dump.cpp(226): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) scene/resources/material.h(289): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) scene/resources/material.h(298): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) editor\editor_themes.cpp(379): warning C4805: '==': unsafe mix of type 'int' and type 'bool' in operation ```
2018-10-03Fix warnings on release builds (not DEBUG_ENABLED)Rémi Verschelde
Fixes the following Clang 5 warnings: ``` modules/bmp/image_loader_bmp.cpp:46:60: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] modules/bmp/image_loader_bmp.cpp:48:61: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] drivers/png/image_loader_png.cpp:231:20: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare] scene/gui/graph_edit.cpp:1045:8: warning: comparison of constant 0 with expression of type 'bool' is always false [-Wtautological-constant-out-of-range-compare] core/class_db.cpp:812:13: warning: unused variable 'check' [-Wunused-variable] core/io/file_access_pack.cpp:172:11: warning: unused variable 'ver_rev' [-Wunused-variable] core/math/bsp_tree.cpp:195:13: warning: unused variable 'plane' [-Wunused-variable] core/math/bsp_tree.cpp:168:6: warning: unused variable 'plane_count' [-Wunused-variable] modules/gdscript/gdscript_function.cpp:685:10: warning: unused variable 'ok' [-Wunused-variable] modules/gdscript/gdscript_function.cpp:706:10: warning: unused variable 'ok' [-Wunused-variable] modules/gdscript/gdscript_function.cpp:755:19: warning: unused variable 'var_type' [-Wunused-variable] modules/gdscript/gdscript_function.cpp:1306:12: warning: unused variable 'err' [-Wunused-variable] modules/gdscript/gdscript_function.cpp:158:15: warning: unused function '_get_var_type' [-Wunused-function] modules/gdscript/gdscript_parser.cpp:750:20: warning: unused variable 'lv' [-Wunused-variable] modules/gdscript/gdscript_parser.cpp:59:15: warning: unused function '_find_function_name' [-Wunused-function] scene/main/node.cpp:2489:13: warning: unused function '_Node_debug_sn' [-Wunused-function] ```
2018-10-03Fix fallback font oversampling.Akeru
2018-10-03Fixed DDS loader according to issue #22530qonnop
width and height attributes have to be switched according to the official DDS header docs: https://docs.microsoft.com/en-us/windows/desktop/direct3ddds/dds-header
2018-10-03Merge pull request #22676 from akien-mga/fix-warningsRémi Verschelde
Fix warnings in Android platform
2018-10-03Fix warnings in Android platformRémi Verschelde
Fixes the following Clang 7 warnings: ``` platform/android/os_android.h:240:16: warning: 'OS_Android::native_video_play' hides overloaded virtual function [-Woverloaded-virtual] platform/android/os_android.h:241:15: warning: 'OS_Android::native_video_is_playing' hides overloaded virtual function [-Woverloaded-virtual] platform/android/audio_driver_opensl.cpp:104:3: warning: suggest braces around initialization of subobject [-Wmissing-braces] platform/android/audio_driver_opensl.cpp:129:10: warning: unused variable 'numOutputs' [-Wunused-variable] platform/android/audio_driver_opensl.cpp:130:11: warning: unused variable 'deviceID' [-Wunused-variable] platform/android/java_glue.cpp:795:10: warning: unused variable 'clsio' [-Wunused-variable] platform/android/java_glue.cpp:890:12: warning: unused variable 'gob' [-Wunused-variable] platform/android/java_glue.cpp:592:13: warning: unused variable 'resized' [-Wunused-variable] platform/android/java_glue.cpp:593:13: warning: unused variable 'resized_reload' [-Wunused-variable] modules/mobile_vr/mobile_vr_interface.cpp:401:8: warning: unused variable 'aspect_ratio' [-Wunused-variable] drivers/unix/dir_access_unix.cpp:394:2: warning: THIS IS BROKEN [-W#warnings] ```
2018-10-03Merge pull request #22672 from akien-mga/fix-warningsRémi Verschelde
Fix various warnings reported by CI in #22620
2018-10-03Fixed error when duplicating node from editor.DualMatrix
Fixed error when duplicating node from editor.
2018-10-03Fix GDNative build warning on Android [-Wignored-attributes]Rémi Verschelde
Fixes the following kind of warning spam: ``` modules/gdnative/include/gdnative/color.h:61:6: warning: calling convention 'sysv_abi' ignored for this target [-Wignored-attributes] void GDAPI godot_color_new_rgba(godot_color *r_dest, const godot_real p_r, const godot_real p_g, const godot_real p_b, const godot_real p_a); ^ modules/gdnative/include/gdnative/gdnative.h:52:15: note: expanded from macro 'GDAPI' ^ modules/gdnative/include/gdnative/gdnative.h:51:38: note: expanded from macro 'GDCALLINGCONV' ^ ```
2018-10-03Fix some more warnings reported by CIRémi Verschelde
Fixes the following Clang 7 warnings: ``` core/io/marshalls.cpp:872:10: warning: unused variable 'f' [-Wunused-variable] core/ustring.cpp:1831:2: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register] core/ustring.cpp:1832:2: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register] drivers/gles3/rasterizer_gles3.cpp:82:24: warning: unused function '_gl_debug_print' [-Wunused-function,34] main/main.cpp:118:13: warning: unused variable 'auto_build_solutions' [-Wunused-variable] modules/csg/csg_gizmos.cpp:225:46: warning: 'current' may be used uninitialized in this function [-Wmaybe-uninitialized] ```
2018-10-03Merge pull request #22668 from groud/add_open_docsRémi Verschelde
Add a shortcut to the documentation in the scene tree RMB menu
2018-10-03Merge pull request #22598 from DualMatrix/animation_frame_nextRémi Verschelde
Fixed animation editor not moving to next frame of sprites when editing.
2018-10-03Merge pull request #22666 from JFonS/noisetexture_remove_sizeRémi Verschelde
Remove redundant size property from NoiseTexture
2018-10-03Add a shortcut to the documentation in the scene tree RMB menugroud
2018-10-03Remove redundant size property from NoiseTextureJFonS
2018-10-03Merge pull request #22657 from YeldhamDev/remove_doc_pathRémi Verschelde
Remove "Doc Path" setting