summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--editor/editor_node.cpp2
-rw-r--r--editor/editor_resource_picker.cpp40
-rw-r--r--editor/editor_resource_picker.h4
3 files changed, 38 insertions, 8 deletions
diff --git a/editor/editor_node.cpp b/editor/editor_node.cpp
index 2dfad8f05a..2c54cb0c6b 100644
--- a/editor/editor_node.cpp
+++ b/editor/editor_node.cpp
@@ -3797,6 +3797,8 @@ void EditorNode::unregister_editor_types() {
if (EditorPaths::get_singleton()) {
EditorPaths::free();
}
+
+ EditorResourcePicker::clear_caches();
}
void EditorNode::stop_child_process(OS::ProcessID p_pid) {
diff --git a/editor/editor_resource_picker.cpp b/editor/editor_resource_picker.cpp
index 9977f5f42c..f3965fe7de 100644
--- a/editor/editor_resource_picker.cpp
+++ b/editor/editor_resource_picker.cpp
@@ -36,6 +36,12 @@
#include "editor_settings.h"
#include "filesystem_dock.h"
+HashMap<StringName, List<StringName>> EditorResourcePicker::allowed_types_cache;
+
+void EditorResourcePicker::clear_caches() {
+ allowed_types_cache.clear();
+}
+
void EditorResourcePicker::_update_resource() {
preview_rect->set_texture(Ref<Texture2D>());
assign_button->set_custom_minimum_size(Size2(1, 1));
@@ -462,17 +468,31 @@ void EditorResourcePicker::_get_allowed_types(bool p_with_convert, Set<String> *
String base = allowed_types[i].strip_edges();
p_vector->insert(base);
- List<StringName> inheriters;
+ // If we hit a familiar base type, take all the data from cache.
+ if (allowed_types_cache.has(base)) {
+ List<StringName> allowed_subtypes = allowed_types_cache[base];
+ for (const StringName &subtype_name : allowed_subtypes) {
+ p_vector->insert(subtype_name);
+ }
+ } else {
+ List<StringName> allowed_subtypes;
- ClassDB::get_inheriters_from_class(base, &inheriters);
- for (const StringName &E : inheriters) {
- p_vector->insert(E);
- }
+ List<StringName> inheriters;
+ ClassDB::get_inheriters_from_class(base, &inheriters);
+ for (const StringName &subtype_name : inheriters) {
+ p_vector->insert(subtype_name);
+ allowed_subtypes.push_back(subtype_name);
+ }
- for (const StringName &E : global_classes) {
- if (EditorNode::get_editor_data().script_class_is_parent(E, base)) {
- p_vector->insert(E);
+ for (const StringName &subtype_name : global_classes) {
+ if (EditorNode::get_editor_data().script_class_is_parent(subtype_name, base)) {
+ p_vector->insert(subtype_name);
+ allowed_subtypes.push_back(subtype_name);
+ }
}
+
+ // Store the subtypes of the base type in the cache for future use.
+ allowed_types_cache[base] = allowed_subtypes;
}
if (p_with_convert) {
@@ -706,6 +726,10 @@ void EditorResourcePicker::set_base_type(const String &p_base_type) {
String class_str = (custom_class == StringName() ? edited_resource->get_class() : vformat("%s (%s)", custom_class, edited_resource->get_class()));
WARN_PRINT(vformat("Value mismatch between the new base type of this EditorResourcePicker, '%s', and the type of the value it already has, '%s'.", base_type, class_str));
}
+ } else {
+ // Call the method to build the cache immediately.
+ Set<String> allowed_types;
+ _get_allowed_types(false, &allowed_types);
}
}
diff --git a/editor/editor_resource_picker.h b/editor/editor_resource_picker.h
index 82a4817dfc..a4c3006c02 100644
--- a/editor/editor_resource_picker.h
+++ b/editor/editor_resource_picker.h
@@ -40,6 +40,8 @@
class EditorResourcePicker : public HBoxContainer {
GDCLASS(EditorResourcePicker, HBoxContainer);
+ static HashMap<StringName, List<StringName>> allowed_types_cache;
+
String base_type;
RES edited_resource;
@@ -97,6 +99,8 @@ protected:
void _notification(int p_what);
public:
+ static void clear_caches();
+
void set_base_type(const String &p_base_type);
String get_base_type() const;
Vector<String> get_allowed_types() const;