summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--platform/macos/display_server_macos.h2
-rw-r--r--platform/macos/display_server_macos.mm10
2 files changed, 7 insertions, 5 deletions
diff --git a/platform/macos/display_server_macos.h b/platform/macos/display_server_macos.h
index fb9bcdfe56..169dd845ed 100644
--- a/platform/macos/display_server_macos.h
+++ b/platform/macos/display_server_macos.h
@@ -188,7 +188,7 @@ private:
Variant tag;
Callable callback;
};
- Vector<MenuCall> deferred_menu_calls;
+ List<MenuCall> deferred_menu_calls;
const NSMenu *_get_menu_root(const String &p_menu_root) const;
NSMenu *_get_menu_root(const String &p_menu_root);
diff --git a/platform/macos/display_server_macos.mm b/platform/macos/display_server_macos.mm
index af80c1c590..2d0335f95a 100644
--- a/platform/macos/display_server_macos.mm
+++ b/platform/macos/display_server_macos.mm
@@ -3491,14 +3491,16 @@ void DisplayServerMacOS::process_events() {
}
// Process "menu_callback"s.
- for (MenuCall &E : deferred_menu_calls) {
- Variant tag = E.tag;
+ while (List<MenuCall>::Element *call_p = deferred_menu_calls.front()) {
+ MenuCall call = call_p->get();
+ deferred_menu_calls.pop_front(); // Remove before call to avoid infinite loop in case callback is using `process_events` (e.g. EditorProgress).
+
+ Variant tag = call.tag;
Variant *tagp = &tag;
Variant ret;
Callable::CallError ce;
- E.callback.callp((const Variant **)&tagp, 1, ret, ce);
+ call.callback.callp((const Variant **)&tagp, 1, ret, ce);
}
- deferred_menu_calls.clear();
if (!drop_events) {
_process_key_events();