Merge pull request #51234 from akien-mga/tests-file-get_csv_line

Tests: Improve coverage for `File::get_csv_line()`

2 files changed, 29 insertions, 5 deletions

diff --git a/tests/data/translations.csv b/tests/data/translations.csv
index 4c9ad4996a..8cb7b800c5 100644
--- a/tests/data/translations.csv
+++ b/tests/data/translations.csv
@@ -1,3 +1,8 @@
 keys,en,de
 GOOD_MORNING,"Good Morning","Guten Morgen"
 GOOD_EVENING,"Good Evening",""
+Without quotes,"With, comma","With ""inner"" quotes","With ""inner"", quotes"","" and comma","With ""inner
+split"" quotes and
+line breaks","With \nnewline chars"
+Some other~delimiter~should still work, shouldn't it?
+What about	tab separated	lines, good?
diff --git a/tests/test_file_access.h b/tests/test_file_access.h
index cb74e08a0d..b3da16c1d1 100644
--- a/tests/test_file_access.h
+++ b/tests/test_file_access.h
@@ -37,12 +37,12 @@
 namespace TestFileAccess {
 
 TEST_CASE("[FileAccess] CSV read") {
-	FileAccess *f = FileAccess::open(TestUtils::get_data_path("translations.csv"), FileAccess::READ);
+	FileAccessRef f = FileAccess::open(TestUtils::get_data_path("translations.csv"), FileAccess::READ);
 
-	Vector<String> header = f->get_csv_line(); // Default delimiter: ","
+	Vector<String> header = f->get_csv_line(); // Default delimiter: ",".
 	REQUIRE(header.size() == 3);
 
-	Vector<String> row1 = f->get_csv_line(",");
+	Vector<String> row1 = f->get_csv_line(","); // Explicit delimiter, should be the same.
 	REQUIRE(row1.size() == 3);
 	CHECK(row1[0] == "GOOD_MORNING");
 	CHECK(row1[1] == "Good Morning");
@@ -53,12 +53,31 @@ TEST_CASE("[FileAccess] CSV read") {
 	CHECK(row2[0] == "GOOD_EVENING");
 	CHECK(row2[1] == "Good Evening");
 	CHECK(row2[2] == ""); // Use case: not yet translated!
-
 	// https://github.com/godotengine/godot/issues/44269
 	CHECK_MESSAGE(row2[2] != "\"", "Should not parse empty string as a single double quote.");
 
+	Vector<String> row3 = f->get_csv_line();
+	REQUIRE(row3.size() == 6);
+	CHECK(row3[0] == "Without quotes");
+	CHECK(row3[1] == "With, comma");
+	CHECK(row3[2] == "With \"inner\" quotes");
+	CHECK(row3[3] == "With \"inner\", quotes\",\" and comma");
+	CHECK(row3[4] == "With \"inner\nsplit\" quotes and\nline breaks");
+	CHECK(row3[5] == "With \\nnewline chars"); // Escaped, not an actual newline.
+
+	Vector<String> row4 = f->get_csv_line("~"); // Custom delimiter, makes inline commas easier.
+	REQUIRE(row4.size() == 3);
+	CHECK(row4[0] == "Some other");
+	CHECK(row4[1] == "delimiter");
+	CHECK(row4[2] == "should still work, shouldn't it?");
+
+	Vector<String> row5 = f->get_csv_line("\t"); // Tab separated variables.
+	REQUIRE(row5.size() == 3);
+	CHECK(row5[0] == "What about");
+	CHECK(row5[1] == "tab separated");
+	CHECK(row5[2] == "lines, good?");
+
 	f->close();
-	memdelete(f);
 }
 } // namespace TestFileAccess