diff options
author | Rémi Verschelde <rverschelde@gmail.com> | 2020-05-14 14:29:06 +0200 |
---|---|---|
committer | Rémi Verschelde <rverschelde@gmail.com> | 2020-05-14 16:54:55 +0200 |
commit | 07bc4e2f96f8f47991339654ff4ab16acc19d44f (patch) | |
tree | 43cdc7cfe8239c23065616a931de3769d2db1e86 /servers/audio/effects/audio_effect_reverb.cpp | |
parent | 0be6d925dc3c6413bce7a3ccb49631b8e4a6e67a (diff) |
Style: Enforce separation line between function definitions
I couldn't find a tool that enforces it, so I went the manual route:
```
find -name "thirdparty" -prune \
-o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \
-o -name "*.glsl" > files
perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files)
misc/scripts/fix_style.sh -c
```
This adds a newline after all `}` on the first column, unless they
are followed by `#` (typically `#endif`). This leads to having lots
of places with two lines between function/class definitions, but
clang-format then fixes it as we enforce max one line of separation.
This doesn't fix potential occurrences of function definitions which
are indented (e.g. for a helper class defined in a .cpp), but it's
better than nothing. Also can't be made to run easily on CI/hooks so
we'll have to be careful with new code.
Part of #33027.
Diffstat (limited to 'servers/audio/effects/audio_effect_reverb.cpp')
-rw-r--r-- | servers/audio/effects/audio_effect_reverb.cpp | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/servers/audio/effects/audio_effect_reverb.cpp b/servers/audio/effects/audio_effect_reverb.cpp index 3169e48d15..f6465abfaf 100644 --- a/servers/audio/effects/audio_effect_reverb.cpp +++ b/servers/audio/effects/audio_effect_reverb.cpp @@ -93,12 +93,15 @@ void AudioEffectReverb::set_predelay_msec(float p_msec) { void AudioEffectReverb::set_predelay_feedback(float p_feedback) { predelay_fb = CLAMP(p_feedback, 0, 0.98); } + void AudioEffectReverb::set_room_size(float p_size) { room_size = p_size; } + void AudioEffectReverb::set_damping(float p_damping) { damping = p_damping; } + void AudioEffectReverb::set_spread(float p_spread) { spread = p_spread; } @@ -106,9 +109,11 @@ void AudioEffectReverb::set_spread(float p_spread) { void AudioEffectReverb::set_dry(float p_dry) { dry = p_dry; } + void AudioEffectReverb::set_wet(float p_wet) { wet = p_wet; } + void AudioEffectReverb::set_hpf(float p_hpf) { hpf = p_hpf; } @@ -116,24 +121,31 @@ void AudioEffectReverb::set_hpf(float p_hpf) { float AudioEffectReverb::get_predelay_msec() const { return predelay; } + float AudioEffectReverb::get_predelay_feedback() const { return predelay_fb; } + float AudioEffectReverb::get_room_size() const { return room_size; } + float AudioEffectReverb::get_damping() const { return damping; } + float AudioEffectReverb::get_spread() const { return spread; } + float AudioEffectReverb::get_dry() const { return dry; } + float AudioEffectReverb::get_wet() const { return wet; } + float AudioEffectReverb::get_hpf() const { return hpf; } |