summaryrefslogtreecommitdiff
path: root/scene
diff options
context:
space:
mode:
authorRĂ©mi Verschelde <rverschelde@gmail.com>2018-10-24 17:39:20 +0200
committerGitHub <noreply@github.com>2018-10-24 17:39:20 +0200
commitd42fd8fa7936ab0f32e207063908cc41dc1ee7ab (patch)
tree79522e6c1860a2ec694dfdcae90a6635094db187 /scene
parentd42850f62e5d64d30955bd3a9bc0ccdff88346b9 (diff)
parent99a097aff2565c38140cab5eca8bba73da8e1008 (diff)
Merge pull request #23256 from JFonS/fix_17989
Fix editor only lights
Diffstat (limited to 'scene')
-rw-r--r--scene/3d/light.cpp9
1 files changed, 2 insertions, 7 deletions
diff --git a/scene/3d/light.cpp b/scene/3d/light.cpp
index 7e1d60ab8e..11d61315ba 100644
--- a/scene/3d/light.cpp
+++ b/scene/3d/light.cpp
@@ -163,11 +163,6 @@ void Light::_update_visibility() {
if (!is_inside_tree())
return;
- // FIXME: Since the call to VS::instance_light_set_enabled was disabled below,
- // the whole logic became pointless so editor_ok triggers unused variable warnings.
- // Commenting out for now but this should be fixed/reimplemented so that editor_only
- // works as expected (GH-17989).
- /*
bool editor_ok = true;
#ifdef TOOLS_ENABLED
@@ -184,8 +179,8 @@ void Light::_update_visibility() {
}
#endif
- //VS::get_singleton()->instance_light_set_enabled(get_instance(),is_visible_in_tree() && editor_ok);
- */
+ VS::get_singleton()->instance_set_visible(get_instance(), is_visible_in_tree() && editor_ok);
+
_change_notify("geometry/visible");
}