Adds warning to the uniform name in visual shader if its equal to keyword

2 files changed, 13 insertions, 0 deletions

diff --git a/scene/resources/visual_shader.cpp b/scene/resources/visual_shader.cpp
index f70f54412b..310a7ef4e4 100644
--- a/scene/resources/visual_shader.cpp
+++ b/scene/resources/visual_shader.cpp
@@ -2164,6 +2164,17 @@ void VisualShaderNodeUniform::_bind_methods() {
 	ADD_PROPERTY(PropertyInfo(Variant::STRING_NAME, "uniform_name"), "set_uniform_name", "get_uniform_name");
 }
 
+String VisualShaderNodeUniform::get_warning(Shader::Mode p_mode, VisualShader::Type p_type) const {
+
+	List<String> keyword_list;
+	ShaderLanguage::get_keyword_list(&keyword_list);
+	if (keyword_list.find(uniform_name)) {
+		return TTR("Uniform name cannot be equal to a shader keyword. Choose another name.");
+	}
+
+	return String();
+}
+
 VisualShaderNodeUniform::VisualShaderNodeUniform() {
 }
 
diff --git a/scene/resources/visual_shader.h b/scene/resources/visual_shader.h
index 450dcfa081..ecf3f93fbb 100644
--- a/scene/resources/visual_shader.h
+++ b/scene/resources/visual_shader.h
@@ -379,6 +379,8 @@ public:
 	void set_uniform_name(const String &p_name);
 	String get_uniform_name() const;
 
+	virtual String get_warning(Shader::Mode p_mode, VisualShader::Type p_type) const;
+
 	VisualShaderNodeUniform();
 };