diff options
| author | Clay John <claynjohn@gmail.com> | 2022-10-27 09:44:21 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-10-27 09:44:21 -0700 |
| commit | 682156e1f0b6fba8debba7c88a0a733e95baaac3 (patch) | |
| tree | fe68cc8655c4a38a7244f3392149aa79fb254ae1 /scene | |
| parent | 7904f70dc438a1b0a644b971c2089383ef776d2f (diff) | |
| parent | 7f9a8c99c93693023a96eb08afd3d9a723663279 (diff) | |
Merge pull request #66383 from aaronfranke/basis-from-euler
Clean up Basis from Euler code
Diffstat (limited to 'scene')
| -rw-r--r-- | scene/3d/node_3d.cpp | 4 | ||||
| -rw-r--r-- | scene/resources/environment.cpp | 2 |
2 files changed, 2 insertions, 4 deletions
diff --git a/scene/3d/node_3d.cpp b/scene/3d/node_3d.cpp index 5f515acead..1743fa1838 100644 --- a/scene/3d/node_3d.cpp +++ b/scene/3d/node_3d.cpp @@ -253,9 +253,7 @@ Vector3 Node3D::get_global_rotation() const { void Node3D::set_global_rotation(const Vector3 &p_euler_rad) { Transform3D transform = get_global_transform(); - Basis new_basis = transform.get_basis(); - new_basis.set_euler(p_euler_rad); - transform.set_basis(new_basis); + transform.basis = Basis::from_euler(p_euler_rad); set_global_transform(transform); } diff --git a/scene/resources/environment.cpp b/scene/resources/environment.cpp index ebdaaaa95f..23bd8a4be4 100644 --- a/scene/resources/environment.cpp +++ b/scene/resources/environment.cpp @@ -78,7 +78,7 @@ float Environment::get_sky_custom_fov() const { void Environment::set_sky_rotation(const Vector3 &p_rotation) { bg_sky_rotation = p_rotation; - RS::get_singleton()->environment_set_sky_orientation(environment, Basis(p_rotation)); + RS::get_singleton()->environment_set_sky_orientation(environment, Basis::from_euler(p_rotation)); } Vector3 Environment::get_sky_rotation() const { |