summaryrefslogtreecommitdiff
path: root/scene/main
diff options
context:
space:
mode:
authorPouleyKetchoupp <pouleyketchoup@gmail.com>2019-10-22 16:28:11 +0200
committerPouleyKetchoupp <pouleyketchoup@gmail.com>2019-10-22 16:28:11 +0200
commite3d4b96ba748c3945d66d018531bb6de86a9c622 (patch)
treec860c35667d7fcc10e883c8854cf80e8ed65b600 /scene/main
parent1be39232b4294f1a1f253426978ab8ed2954b05a (diff)
Fixed crashes when renaming a state in AnimationNodeStateMachineEditor
Recursive calls to Control::_modal_stack_remove could cause a crash because of the list element not being invalidated while being erased from the list. It happens in the state machine case by hiding a line edit control when it loses focus. Fixes #23808
Diffstat (limited to 'scene/main')
-rw-r--r--scene/main/viewport.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/scene/main/viewport.cpp b/scene/main/viewport.cpp
index 52ef225364..95536bbb23 100644
--- a/scene/main/viewport.cpp
+++ b/scene/main/viewport.cpp
@@ -2374,7 +2374,6 @@ void Viewport::_gui_remove_from_modal_stack(List<Control *>::Element *MI, Object
List<Control *>::Element *next = MI->next();
gui.modal_stack.erase(MI);
- MI = NULL;
if (p_prev_focus_owner) {