summaryrefslogtreecommitdiff
path: root/scene/main
diff options
context:
space:
mode:
authorlawnjelly <lawnjelly@gmail.com>2022-01-19 19:46:17 +0000
committerlawnjelly <lawnjelly@gmail.com>2022-01-20 13:07:49 +0000
commitb411a731fef9af1c0a73e4d5b718e5a6b12af1c2 (patch)
treeaae207a63b24f823efef9901e92b5222e2f3618b /scene/main
parent249c60e9d1aacd07d87786db8059f30aed02bb68 (diff)
Add nodiscard to core math classes to catch c++ errors.
A common source of errors is to call functions (such as round()) expecting them to work in place, but them actually being designed only to return the processed value. Not using the return value in this case in indicative of a bug, and can be flagged as a warning by using the [[nodiscard]] attribute.
Diffstat (limited to 'scene/main')
-rw-r--r--scene/main/canvas_item.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/scene/main/canvas_item.cpp b/scene/main/canvas_item.cpp
index 59d933fa1d..a0916c6291 100644
--- a/scene/main/canvas_item.cpp
+++ b/scene/main/canvas_item.cpp
@@ -1017,8 +1017,8 @@ void CanvasItem::set_notify_transform(bool p_enable) {
notify_transform = p_enable;
if (notify_transform && is_inside_tree()) {
- //this ensures that invalid globals get resolved, so notifications can be received
- get_global_transform();
+ // This ensures that invalid globals get resolved, so notifications can be received.
+ _ALLOW_DISCARD_ get_global_transform();
}
}