diff options
author | Bojidar Marinov <bojidar.marinov.bg@gmail.com> | 2019-07-10 21:03:04 +0300 |
---|---|---|
committer | Bojidar Marinov <bojidar.marinov.bg@gmail.com> | 2019-07-10 21:03:04 +0300 |
commit | 8ecbb6a20d7d28273273297b2994491f8adc2500 (patch) | |
tree | d024979c623e33b8a9a7a1f63fd81bf765fdcfd2 /scene/main | |
parent | 3bfffcc568d87342e867f95c35a4a19e09072189 (diff) |
Fix inability to insert keys via Insert Key context menu
Fixes #30495
Diffstat (limited to 'scene/main')
-rw-r--r-- | scene/main/node.cpp | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/scene/main/node.cpp b/scene/main/node.cpp index 5888760973..ac381f39fe 100644 --- a/scene/main/node.cpp +++ b/scene/main/node.cpp @@ -2487,7 +2487,7 @@ bool Node::has_node_and_resource(const NodePath &p_path) const { Vector<StringName> leftover_path; Node *node = get_node_and_resource(p_path, res, leftover_path, false); - return (node && res.is_valid()); + return node; } Array Node::_get_node_and_resource(const NodePath &p_path) { @@ -2525,9 +2525,15 @@ Node *Node::get_node_and_resource(const NodePath &p_path, RES &r_res, Vector<Str int j = 0; // If not p_last_is_property, we shouldn't consider the last one as part of the resource for (; j < p_path.get_subname_count() - (int)p_last_is_property; j++) { - RES new_res = j == 0 ? node->get(p_path.get_subname(j)) : r_res->get(p_path.get_subname(j)); + Variant new_res_v = j == 0 ? node->get(p_path.get_subname(j)) : r_res->get(p_path.get_subname(j)); + + if (new_res_v.get_type() == Variant::NIL) { // Found nothing on that path + return NULL; + } + + RES new_res = new_res_v; - if (new_res.is_null()) { + if (new_res.is_null()) { // No longer a resource, assume property break; } |