diff options
author | RĂ©mi Verschelde <remi@verschelde.fr> | 2021-07-07 16:36:13 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-07-07 16:36:13 +0200 |
commit | 48a52268291d2dc48377c51f1b43e0a9d830057e (patch) | |
tree | 2e77e9f8d1b226c63f06886d7eda1cf1bbb87ae4 /scene/main | |
parent | f62da984afbe1e689d2dae0acb49eb783672de27 (diff) | |
parent | d41e3f9aebf294ccb6238795b8cfb3c815ea3a93 (diff) |
Merge pull request #50193 from reduz/fix-command-queue-crash
Fix Command Queue Crash
Diffstat (limited to 'scene/main')
-rw-r--r-- | scene/main/shader_globals_override.cpp | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/scene/main/shader_globals_override.cpp b/scene/main/shader_globals_override.cpp index 3d65c12cb7..d22a6b2875 100644 --- a/scene/main/shader_globals_override.cpp +++ b/scene/main/shader_globals_override.cpp @@ -63,7 +63,12 @@ bool ShaderGlobalsOverride::_set(const StringName &p_name, const Variant &p_valu if (o) { o->override = p_value; if (active) { - RS::get_singleton()->global_variable_set_override(*r, p_value); + if (o->override.get_type() == Variant::OBJECT) { + RID tex_rid = p_value; + RS::get_singleton()->global_variable_set_override(*r, tex_rid); + } else { + RS::get_singleton()->global_variable_set_override(*r, p_value); + } } o->in_use = p_value.get_type() != Variant::NIL; return true; @@ -228,7 +233,12 @@ void ShaderGlobalsOverride::_activate() { while ((K = overrides.next(K))) { Override *o = overrides.getptr(*K); if (o->in_use && o->override.get_type() != Variant::NIL) { - RS::get_singleton()->global_variable_set_override(*K, o->override); + if (o->override.get_type() == Variant::OBJECT) { + RID tex_rid = o->override; + RS::get_singleton()->global_variable_set_override(*K, tex_rid); + } else { + RS::get_singleton()->global_variable_set_override(*K, o->override); + } } } |