Merge pull request #25298 from groud/fix_separation_update

Updates containers minimum size when some constants are modified

1 files changed, 83 insertions, 76 deletions

diff --git a/scene/gui/graph_node.cpp b/scene/gui/graph_node.cpp
index 7c879d239c..8c588109d6 100644
--- a/scene/gui/graph_node.cpp
+++ b/scene/gui/graph_node.cpp
@@ -192,97 +192,104 @@ bool GraphNode::has_point(const Point2 &p_point) const {
 
 void GraphNode::_notification(int p_what) {
 
-	if (p_what == NOTIFICATION_DRAW) {
+	switch (p_what) {
+		case NOTIFICATION_DRAW: {
 
-		Ref<StyleBox> sb;
+			Ref<StyleBox> sb;
 
-		if (comment) {
-			sb = get_stylebox(selected ? "commentfocus" : "comment");
+			if (comment) {
+				sb = get_stylebox(selected ? "commentfocus" : "comment");
 
-		} else {
+			} else {
 
-			sb = get_stylebox(selected ? "selectedframe" : "frame");
-		}
+				sb = get_stylebox(selected ? "selectedframe" : "frame");
+			}
 
-		//sb=sb->duplicate();
-		//sb->call("set_modulate",modulate);
-		Ref<Texture> port = get_icon("port");
-		Ref<Texture> close = get_icon("close");
-		Ref<Texture> resizer = get_icon("resizer");
-		int close_offset = get_constant("close_offset");
-		int close_h_offset = get_constant("close_h_offset");
-		Color close_color = get_color("close_color");
-		Ref<Font> title_font = get_font("title_font");
-		int title_offset = get_constant("title_offset");
-		int title_h_offset = get_constant("title_h_offset");
-		Color title_color = get_color("title_color");
-		Point2i icofs = -port->get_size() * 0.5;
-		int edgeofs = get_constant("port_offset");
-		icofs.y += sb->get_margin(MARGIN_TOP);
-
-		draw_style_box(sb, Rect2(Point2(), get_size()));
-
-		switch (overlay) {
-			case OVERLAY_DISABLED: {
-
-			} break;
-			case OVERLAY_BREAKPOINT: {
-
-				draw_style_box(get_stylebox("breakpoint"), Rect2(Point2(), get_size()));
-			} break;
-			case OVERLAY_POSITION: {
-				draw_style_box(get_stylebox("position"), Rect2(Point2(), get_size()));
-
-			} break;
-		}
+			//sb=sb->duplicate();
+			//sb->call("set_modulate",modulate);
+			Ref<Texture> port = get_icon("port");
+			Ref<Texture> close = get_icon("close");
+			Ref<Texture> resizer = get_icon("resizer");
+			int close_offset = get_constant("close_offset");
+			int close_h_offset = get_constant("close_h_offset");
+			Color close_color = get_color("close_color");
+			Ref<Font> title_font = get_font("title_font");
+			int title_offset = get_constant("title_offset");
+			int title_h_offset = get_constant("title_h_offset");
+			Color title_color = get_color("title_color");
+			Point2i icofs = -port->get_size() * 0.5;
+			int edgeofs = get_constant("port_offset");
+			icofs.y += sb->get_margin(MARGIN_TOP);
+
+			draw_style_box(sb, Rect2(Point2(), get_size()));
+
+			switch (overlay) {
+				case OVERLAY_DISABLED: {
+
+				} break;
+				case OVERLAY_BREAKPOINT: {
+
+					draw_style_box(get_stylebox("breakpoint"), Rect2(Point2(), get_size()));
+				} break;
+				case OVERLAY_POSITION: {
+					draw_style_box(get_stylebox("position"), Rect2(Point2(), get_size()));
+
+				} break;
+			}
 
-		int w = get_size().width - sb->get_minimum_size().x;
+			int w = get_size().width - sb->get_minimum_size().x;
 
-		if (show_close)
-			w -= close->get_width();
+			if (show_close)
+				w -= close->get_width();
 
-		draw_string(title_font, Point2(sb->get_margin(MARGIN_LEFT) + title_h_offset, -title_font->get_height() + title_font->get_ascent() + title_offset), title, title_color, w);
-		if (show_close) {
-			Vector2 cpos = Point2(w + sb->get_margin(MARGIN_LEFT) + close_h_offset, -close->get_height() + close_offset);
-			draw_texture(close, cpos, close_color);
-			close_rect.position = cpos;
-			close_rect.size = close->get_size();
-		} else {
-			close_rect = Rect2();
-		}
+			draw_string(title_font, Point2(sb->get_margin(MARGIN_LEFT) + title_h_offset, -title_font->get_height() + title_font->get_ascent() + title_offset), title, title_color, w);
+			if (show_close) {
+				Vector2 cpos = Point2(w + sb->get_margin(MARGIN_LEFT) + close_h_offset, -close->get_height() + close_offset);
+				draw_texture(close, cpos, close_color);
+				close_rect.position = cpos;
+				close_rect.size = close->get_size();
+			} else {
+				close_rect = Rect2();
+			}
 
-		for (Map<int, Slot>::Element *E = slot_info.front(); E; E = E->next()) {
-
-			if (E->key() < 0 || E->key() >= cache_y.size())
-				continue;
-			if (!slot_info.has(E->key()))
-				continue;
-			const Slot &s = slot_info[E->key()];
-			//left
-			if (s.enable_left) {
-				Ref<Texture> p = port;
-				if (s.custom_slot_left.is_valid()) {
-					p = s.custom_slot_left;
+			for (Map<int, Slot>::Element *E = slot_info.front(); E; E = E->next()) {
+
+				if (E->key() < 0 || E->key() >= cache_y.size())
+					continue;
+				if (!slot_info.has(E->key()))
+					continue;
+				const Slot &s = slot_info[E->key()];
+				//left
+				if (s.enable_left) {
+					Ref<Texture> p = port;
+					if (s.custom_slot_left.is_valid()) {
+						p = s.custom_slot_left;
+					}
+					p->draw(get_canvas_item(), icofs + Point2(edgeofs, cache_y[E->key()]), s.color_left);
 				}
-				p->draw(get_canvas_item(), icofs + Point2(edgeofs, cache_y[E->key()]), s.color_left);
-			}
-			if (s.enable_right) {
-				Ref<Texture> p = port;
-				if (s.custom_slot_right.is_valid()) {
-					p = s.custom_slot_right;
+				if (s.enable_right) {
+					Ref<Texture> p = port;
+					if (s.custom_slot_right.is_valid()) {
+						p = s.custom_slot_right;
+					}
+					p->draw(get_canvas_item(), icofs + Point2(get_size().x - edgeofs, cache_y[E->key()]), s.color_right);
 				}
-				p->draw(get_canvas_item(), icofs + Point2(get_size().x - edgeofs, cache_y[E->key()]), s.color_right);
 			}
-		}
 
-		if (resizable) {
-			draw_texture(resizer, get_size() - resizer->get_size());
-		}
-	}
+			if (resizable) {
+				draw_texture(resizer, get_size() - resizer->get_size());
+			}
+		} break;
+
+		case NOTIFICATION_SORT_CHILDREN: {
+
+			_resort();
+		} break;
 
-	if (p_what == NOTIFICATION_SORT_CHILDREN) {
+		case NOTIFICATION_THEME_CHANGED: {
 
-		_resort();
+			minimum_size_changed();
+		} break;
 	}
 }