diff options
author | Ignacio Etcheverry <neikeq@users.noreply.github.com> | 2019-03-01 00:40:37 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-03-01 00:40:37 +0100 |
commit | 8d117b214f2bcd14015532fdfbed9b3f059da0e6 (patch) | |
tree | c6a2df3d1cf848874c4d72e0e04f83447211e3a0 /modules | |
parent | ba9bfb8593de9d97260c6afee59e7df87c6fb3ec (diff) | |
parent | 42c57eef13262c8c92c0f195bc5dc82d605aad97 (diff) |
Merge pull request #26425 from neikeq/issue-24958
C#: Fix parsing of class full name when the base has generics
Diffstat (limited to 'modules')
-rw-r--r-- | modules/mono/editor/script_class_parser.cpp | 25 |
1 files changed, 11 insertions, 14 deletions
diff --git a/modules/mono/editor/script_class_parser.cpp b/modules/mono/editor/script_class_parser.cpp index fcc58c22e8..6b2ec5cc20 100644 --- a/modules/mono/editor/script_class_parser.cpp +++ b/modules/mono/editor/script_class_parser.cpp @@ -322,6 +322,15 @@ Error ScriptClassParser::_parse_type_full_name(String &r_full_name) { r_full_name += String(value); + if (code[idx] == '<') { + idx++; + + // We don't mind if the base is generic, but we skip it any ways since this information is not needed + Error err = _skip_generic_type_params(); + if (err) + return err; + } + if (code[idx] != '.') // We only want to take the next token if it's a period return OK; @@ -344,16 +353,6 @@ Error ScriptClassParser::_parse_class_base(Vector<String> &r_base) { Token tk = get_token(); - bool generic = false; - if (tk == TK_OP_LESS) { - err = _skip_generic_type_params(); - if (err) - return err; - // We don't add it to the base list if it's generic - generic = true; - tk = get_token(); - } - if (tk == TK_COMMA) { err = _parse_class_base(r_base); if (err) @@ -373,9 +372,7 @@ Error ScriptClassParser::_parse_class_base(Vector<String> &r_base) { return ERR_PARSE_ERROR; } - if (!generic) { - r_base.push_back(name); - } + r_base.push_back(name); return OK; } @@ -567,7 +564,7 @@ Error ScriptClassParser::parse(const String &p_code) { if (full_name.length()) full_name += "."; full_name += class_decl.name; - OS::get_singleton()->print("%s", String("Ignoring generic class declaration: " + class_decl.name).utf8().get_data()); + OS::get_singleton()->print("Ignoring generic class declaration: %s\n", class_decl.name.utf8().get_data()); } } } else if (tk == TK_IDENTIFIER && String(value) == "struct") { |