diff options
| author | George Marques <george@gmarqu.es> | 2023-01-11 14:24:23 -0300 |
|---|---|---|
| committer | George Marques <george@gmarqu.es> | 2023-01-11 14:24:23 -0300 |
| commit | 66fda2aeea84395b69c8d94d6957927699976e6c (patch) | |
| tree | c0739aab4c0438ffb063dc019a7483c2e2fd38ff /modules/gdscript/tests/scripts | |
| parent | 2ac2db8de5289b4f097eac89485d95d8e5281a84 (diff) | |
GDScript: Fix temp values being written without proper clear
Temporary values in the stack were not being properly cleared when the
return value of calls were discarded, which can cause memory issues
especially for reference types like PackedByteArray.
Diffstat (limited to 'modules/gdscript/tests/scripts')
| -rw-r--r-- | modules/gdscript/tests/scripts/runtime/features/does_not_override_temp_values.gd | 17 | ||||
| -rw-r--r-- | modules/gdscript/tests/scripts/runtime/features/does_not_override_temp_values.out | 2 |
2 files changed, 19 insertions, 0 deletions
diff --git a/modules/gdscript/tests/scripts/runtime/features/does_not_override_temp_values.gd b/modules/gdscript/tests/scripts/runtime/features/does_not_override_temp_values.gd new file mode 100644 index 0000000000..1d4b400d81 --- /dev/null +++ b/modules/gdscript/tests/scripts/runtime/features/does_not_override_temp_values.gd @@ -0,0 +1,17 @@ +# https://github.com/godotengine/godot/issues/71177 + +func test(): + builtin_method() + builtin_method_static() + print("done") + +func builtin_method(): + var pba := PackedByteArray() + @warning_ignore(return_value_discarded) + pba.resize(1) # Built-in validated. + + +func builtin_method_static(): + var _pba := PackedByteArray() + @warning_ignore(return_value_discarded) + Vector2.from_angle(PI) # Static built-in validated. diff --git a/modules/gdscript/tests/scripts/runtime/features/does_not_override_temp_values.out b/modules/gdscript/tests/scripts/runtime/features/does_not_override_temp_values.out new file mode 100644 index 0000000000..8e68c97774 --- /dev/null +++ b/modules/gdscript/tests/scripts/runtime/features/does_not_override_temp_values.out @@ -0,0 +1,2 @@ +GDTEST_OK +done |